Skip to content

Make it more bare minimum#2

Merged
lupomontero merged 1 commit into
lupomontero:masterfrom
kul:master
Apr 13, 2012
Merged

Make it more bare minimum#2
lupomontero merged 1 commit into
lupomontero:masterfrom
kul:master

Conversation

@kul

@kul kul commented Apr 5, 2012

Copy link
Copy Markdown
Contributor

No description provided.

@lupomontero

Copy link
Copy Markdown
Owner

Hi kul,

Thanks for the feedback and changes ;-)

With regards to this pull request, I have added some inline comments on the commit:

kul@d309d73#L0R13

@kul

kul commented Apr 13, 2012

Copy link
Copy Markdown
Contributor Author

Hi lupomontero,
sorry initd was a typo from my side, as far as exporting a init function is concerned i am sure the exposed MACRO NODE_MODULE would de doing something similar to extern "C". The idea is that the module is run by nodejs in a sandbox and by default init is called. But its entirely up to you..if you think NODE_MODULE brings more clarity.

@lupomontero

Copy link
Copy Markdown
Owner

I guess the original aim of this example was to go as minimal as possible, so Im merging the pull request. I'll fix the typo in the function name...

lupomontero pushed a commit that referenced this pull request Apr 13, 2012
Make it more bare minimum
@lupomontero lupomontero merged commit 53fbd6e into lupomontero:master Apr 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants