Make it more bare minimum #2

Merged
merged 1 commit into from Apr 13, 2012

Projects

None yet

2 participants

@kul
Contributor
kul commented Apr 5, 2012

No description provided.

@lupomontero

Shouldn't initd be init instead? Changing it to init seems to work, but Im not sure if I want to remove the call to NODE_MODULE as the documentation states that:

Note that all Node addons must export an initialization function

See http://nodejs.org/api/addons.html#apicontent

@lupomontero
Owner

Hi kul,

Thanks for the feedback and changes ;-)

With regards to this pull request, I have added some inline comments on the commit:

kul@d309d73#L0R13

@kul
Contributor
kul commented Apr 13, 2012

Hi lupomontero,
sorry initd was a typo from my side, as far as exporting a init function is concerned i am sure the exposed MACRO NODE_MODULE would de doing something similar to extern "C". The idea is that the module is run by nodejs in a sandbox and by default init is called. But its entirely up to you..if you think NODE_MODULE brings more clarity.

@lupomontero
Owner

I guess the original aim of this example was to go as minimal as possible, so Im merging the pull request. I'll fix the typo in the function name...

@lupomontero lupomontero merged commit 53fbd6e into lupomontero:master Apr 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment