Added stopPropagation and preventDefault to onChange #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug when you wrap react-icheck in a label, as it currently will trigger the onChange event twice (once when you click the checkbox, once when the event bubbles up to the label). This is inline with ichecks implementation see https://github.com/fronteed/icheck/blob/1.x/icheck.js#L218
alex-e-leon
force-pushed
the
stop-propagation
branch
from
d1b2d74
to
fb7ec4e
Compare
luqin
pushed a commit
that referenced
this pull request
Jan 18, 2016
Added stopPropagation and preventDefault to onChange
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when you wrap react-icheck in a label, as it currently
will trigger the onChange event twice (once when you click the checkbox,
once when the event bubbles up to the label).
This is inline with ichecks implementation see
https://github.com/fronteed/icheck/blob/1.x/icheck.js#L218
Note, that I'd prefer to not stop the event bubble chain, but due to ichecks implementation, I'm not sure there's any other way to fix this bug.