Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added className prop for outer label #8

Merged
merged 2 commits into from
Oct 8, 2016
Merged

Added className prop for outer label #8

merged 2 commits into from
Oct 8, 2016

Conversation

isomoar
Copy link
Contributor

@isomoar isomoar commented Dec 26, 2015

I think outer element which wraps radio button and label needs optional className property

@luqin
Copy link
Owner

luqin commented Dec 27, 2015

@isomoar Thanks for you PR. How about outerLabelClassName => labelClassName ?

@isomoar
Copy link
Contributor Author

isomoar commented Dec 27, 2015

@luqin OK, just updated to labelClassName.

@luqin luqin mentioned this pull request Jan 18, 2016
6 tasks
@luqin
Copy link
Owner

luqin commented Jan 18, 2016

@isomoar Hi. How about add className like this

// these are a default classnames used by icheck (# are replaced with classes.base)
  classes: {
    base: 'icheck', // classname to search for and customize
    div: '#-item', // classname to add for a styler div
    area: '#-area-', // classname to add to styler, when "area" option is used
    input: '#-input', // classname to add to original input
    label: '#-label' // classname to add to assigned labels
  },

from https://github.com/fronteed/icheck/tree/2.x#these-are-global-object-options

khmm12 added a commit to khmm12/react-icheck that referenced this pull request Feb 17, 2016
khmm12 added a commit to khmm12/react-icheck that referenced this pull request May 18, 2016
@cvetanov
Copy link
Contributor

cvetanov commented Oct 3, 2016

Hi @luqin, I encountered a problem when trying to add css rules for the span element inside the label. This pull request solves my problem by adding a class to the outer label so the css rules can be more specific, but it fails on Travis because of es-lint settings (no-trailing-spaces). Can you fix this simple problem and merge the PR?

Keep me informed and if there are some problems, I'll be happy to make a PR myself and fix this.

Thanks,
Goce

@luqin luqin merged commit 9c5f018 into luqin:master Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants