New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some pages not working #26

Closed
dupontjoy opened this Issue Aug 27, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@dupontjoy

dupontjoy commented Aug 27, 2017

@eejdoowad

This comment has been minimized.

Show comment
Hide comment
@eejdoowad

eejdoowad Aug 28, 2017

Member

This is a Firefox-only bug I think might be related to #24. Thanks for the examples. Still working on it, but I've been a little busy lately.

Member

eejdoowad commented Aug 28, 2017

This is a Firefox-only bug I think might be related to #24. Thanks for the examples. Still working on it, but I've been a little busy lately.

@dupontjoy

This comment has been minimized.

Show comment
Hide comment
@dupontjoy

dupontjoy Aug 28, 2017

thanks, hope saka gets better and better

dupontjoy commented Aug 28, 2017

thanks, hope saka gets better and better

@eejdoowad

This comment has been minimized.

Show comment
Hide comment
@eejdoowad

eejdoowad Aug 28, 2017

Member

I've isolated the bug to window.handleDOMEvent (the function that passes events to Saka Key's modes) being inexplicably undefined despite a successful assignment at line https://github.com/lusakasa/saka-key/blob/master/src/client/modes.js#L45.

Installing event listeners is a little (too) complicated to satisfy all the requirements, and it seems like Firefox doesn't like how window.handleDOMEvent is redefined dynamically in a separate script.

In terms unrelated to Saka Key, this is the problem:

Content script A adds an event listener L to the window which calls a function window.F I attached to the window. The content script loads another content script B which redefines the function window.F. Problem is, on some web pages this works fine, on others window.F is inexplicably undefined

Member

eejdoowad commented Aug 28, 2017

I've isolated the bug to window.handleDOMEvent (the function that passes events to Saka Key's modes) being inexplicably undefined despite a successful assignment at line https://github.com/lusakasa/saka-key/blob/master/src/client/modes.js#L45.

Installing event listeners is a little (too) complicated to satisfy all the requirements, and it seems like Firefox doesn't like how window.handleDOMEvent is redefined dynamically in a separate script.

In terms unrelated to Saka Key, this is the problem:

Content script A adds an event listener L to the window which calls a function window.F I attached to the window. The content script loads another content script B which redefines the function window.F. Problem is, on some web pages this works fine, on others window.F is inexplicably undefined

@eejdoowad

This comment has been minimized.

Show comment
Hide comment
@eejdoowad

eejdoowad Aug 29, 2017

Member

My latest commit should resolve this issue. I'll publish it to the dev channel of the add-ons marketplace shortly. If this problem persists, please let me know.

Member

eejdoowad commented Aug 29, 2017

My latest commit should resolve this issue. I'll publish it to the dev channel of the add-ons marketplace shortly. If this problem persists, please let me know.

@eejdoowad eejdoowad closed this Aug 29, 2017

eejdoowad added a commit that referenced this issue Aug 31, 2017

When I rewrote the options page logic for v.1.16, I fix some old bugs…
…... and introduced some new ones. One unfortunate consequence is I unknowingly broke the code that generated the keybindings that are sent to every client. This release hopefully corrects this defect and puts an end to issues with options and unresponsive pages (#26, #27, #29). Hopefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment