Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Mozilla's webextension-polyfill package #97

Merged
merged 1 commit into from Apr 10, 2019

Conversation

Projects
None yet
3 participants
@eejdoowad
Copy link
Member

commented Apr 10, 2019

Type of Change

Put an [x] for the relevant option

  • Bugfix/Cleanup (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Summary Of Changes

Why is this change needed?

Mozilla authors and supports the webextension-polyfill package so we don't have to.

Does this close any open issues?

No

Checklist

  • Tests are passing locally
  • Updated the README/Wiki documentation (if relevant)

Additional Comments

Add any additional comments you may have here.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 10, 2019

Codecov Report

Merging #97 into master will increase coverage by 0.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #97      +/-   ##
=========================================
+ Coverage   58.26%   58.5%   +0.24%     
=========================================
  Files          58      57       -1     
  Lines         714     711       -3     
  Branches       65      65              
=========================================
  Hits          416     416              
+ Misses        267     264       -3     
  Partials       31      31
Impacted Files Coverage Δ
src/options/Main/OptionsList/index.jsx 100% <ø> (ø) ⬆️
src/saka/index.jsx 0% <ø> (ø) ⬆️
src/suggestion_engine/server/providers/history.js 100% <ø> (ø) ⬆️
src/suggestion_engine/server/providers/bookmark.js 100% <ø> (ø) ⬆️
src/lib/url.js 88.88% <ø> (ø) ⬆️
...rc/suggestion_engine/server/providers/closedTab.js 96.55% <ø> (ø) ⬆️
src/options/saka-options.jsx 0% <ø> (ø) ⬆️
src/suggestion_engine/server/index.js 95.23% <ø> (ø) ⬆️
src/suggestion_engine/server/providers/tab.js 100% <ø> (ø) ⬆️
src/saka/Main/index.jsx 21.87% <ø> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c37da...d12ceaa. Read the comment docs.

@pureooze
Copy link
Member

left a comment

LGTM

@pureooze pureooze merged commit 3e1259a into lusakasa:master Apr 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.