Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add arbitrary "data" field to service; Improved exception handling #19

wants to merge 2 commits into


None yet
1 participant

ilyash commented Oct 4, 2012

  • The additional data field can describe further endpoint properties such as service port.
  • Let Sinatra to handle the exceptions

ilyash added some commits Oct 4, 2012

Noah models - allow Sinatra to handle the exceptions.
Previous behavior was that lib/noah/models/* could return
exception as a string insted of an object. It's better to
let Sinatra to handle the exceptions.

This changes the exception returned by REST API, for example:
Old: undefined method `valid?' for #<String:0xDEADBEEF>
New: Connection refused - Unable to connect to Redis on ...

@ilyash ilyash referenced this pull request in jamtur01/puppet-noah Oct 11, 2012


Add support for arbitrary "data" field of a service #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment