New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lutris syncs STEAM games when sync is turned off (library) #962

Closed
BloodyIron opened this Issue Jul 6, 2018 · 28 comments

Comments

Projects
8 participants
@BloodyIron
Copy link

BloodyIron commented Jul 6, 2018

I didn't turn sync on, and so far as I can tell, it's off (the slider is set to off) to sync with STEAM.

But Lutris keeps syncing my STEAM library with its library, and I don't want it to!

I'm on 0.4.18.

I've heard this happening to other people too. Thanks! :D

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Jul 21, 2018

This is still happening for me :(

@strycore

This comment has been minimized.

Copy link
Member

strycore commented Aug 16, 2018

I think what's happening is that Lutris is syncing your Lutris library, which contains all your Steam games if your have synced your library on the website. The game Lutris sees as installed as likely to be marked as such.

@strycore strycore added this to the 0.4.19 milestone Aug 16, 2018

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Aug 16, 2018

But I don't think I've synced my STEAM library on the Lutris website. Um, where would I check that?

This still seems the opposite of what I think would be reasonable behaviour as the sync setting is turned off in the client.

@NicoVIII

This comment has been minimized.

Copy link
Contributor

NicoVIII commented Aug 21, 2018

As far as I know, Lutris does not delete a game from the library on the lutris homepage, if you delete it in the lutris application. So if you have a lutris account connected, the game will always show up again, if you don't delete it on the website.

You could test, if this is your problem by deleting a game you think is imported through steam on the lutris website and then delete it in the lutris application and restart.

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Aug 21, 2018

I don't have the program logged into my account. It's pulling from the native STEAM library I have on the same system.

@KonomiKitten

This comment has been minimized.

Copy link

KonomiKitten commented Aug 21, 2018

I don't have the program logged into my account. It's pulling from the native STEAM library I have on the same system.

I also have the same problem and I'm also not logged into any account that has to do with Lutris.

@keturn

This comment has been minimized.

Copy link
Contributor

keturn commented Aug 22, 2018

I was going to take a shot at this one, as I've seen it myself.

After a little testing, it seems like the entry isn't imported when Lutris starts, it's imported when the local Steam client starts.

Ah, okay, I got it to trigger again:

LutrisWindow.__init__ sets up a SteamWatcher, with callback LutrisWindow.on_steam_game_changed, and that will do a mark_as_installed, and it doesn't seem to be checking any sort of "should I sync?" in the process.

When is it the right time for it to check that? Should it not start the SteamWatcher at all, if it's not set up to sync?

Or does the first part of on_steam_game_changed, the part that works with running_game, still need to get updated, but it should stop after that if sync isn't on?

@NicoVIII

This comment has been minimized.

Copy link
Contributor

NicoVIII commented Aug 22, 2018

After @keturn s work I could reproduce as well. If steam and lutris are open and I install a game, lutris adds it.

I guess that lutris removes a game if it is uninstalled from steam is useful even without enabled syncing because the game can not be started from lutris anymore. But if live syncing is fixed, we should change the text as well. For now it justs says that libraries are synced when lutris starts.

Just to put my two cents in. 😄

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Aug 22, 2018

I don't want it to sync with sync set to off, whether I'm logged in or not. It creates too much clutter!

@tannisroot

This comment has been minimized.

Copy link
Contributor

tannisroot commented Aug 24, 2018

Can confirm that this is an issue for me ass well. Very annoying.

@tannisroot

This comment has been minimized.

Copy link
Contributor

tannisroot commented Sep 1, 2018

video proof: https://youtu.be/PGBpNluU73s
seems like it needs lutris actually running along with steam

@strycore strycore modified the milestones: 0.4.19, 0.4.20 Sep 6, 2018

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Sep 15, 2018

Can we PLEASE get this addressed? My Lutris is crammed with games that I normally just launch straight through STEAM and I DID NOT tell it to sync.

@KonomiKitten

This comment has been minimized.

Copy link

KonomiKitten commented Oct 1, 2018

I noticed the milestone was set to 0.4.20 which recently released but I don't see anything in the release notes about this problem, can I presume it will now be bumped as a milestone for the next version? Little disappointing.

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Oct 1, 2018

Yeah, I really want this extremely frustrating behaviour to stop. When is it going mainline?

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Oct 4, 2018

Okay it's now syncing games that are already installed.

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Oct 5, 2018

Today it synced 17 games that were already installed. I didn't tell it to do this. I have to manually go and remove these each time they do this. This is ridiculous can we PLEASE get this fixed???

@tannisroot

This comment has been minimized.

Copy link
Contributor

tannisroot commented Oct 6, 2018

I see that Lutris still watches the steam library folder, even when the syncing is turned off.
Perhaps stopping that behavior would solve this issue.

@moll

This comment has been minimized.

Copy link

moll commented Oct 6, 2018

#962 (comment) described the problem technically and I found the same root cause in the source code. I suppose those that can code can remove the watcher initialization in

self.steam_watcher = SteamWatcher(steamapps_paths, self.on_steam_game_changed)
from their local install until a permanent solution is put in place.

@Medath

This comment has been minimized.

Copy link
Contributor

Medath commented Oct 6, 2018

What is everyone here talking about? It doesn't seem to me like Lutris even has an option to disable syncing (At least I couldn't find it). So how can it be bugged if it doesn't even exist? What everyone here is probably talking about is the option to disable sync when Lutris starts, which seems to work just as it should.

That being said, it's not very clear and can be easily confused as an option to disable sync entirely. I think it would be better to rename this issue to something like "Add option to fully disable game sync".

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Oct 6, 2018

Syncing SHOULD be disabled by default, but clearly it isn't. My understanding is that syncing with the STEAM install on the same computer typically relies on logging into a Lutris account and then enabling/disabling per runner. But the thing is Lutris is syncing for me, without logging in, and without telling it to, and I have ZERO way to tell it to stop.

I want it to NOT sync by default, and for this shit to just stop already.

I've had Lutris sync games while it was running, I did not have to re-run it for syncing to happen.

Again, I want it OFF BY DEFAULT AND the ability to turn it off/on.

@moll

This comment has been minimized.

Copy link

moll commented Oct 6, 2018

@Medath, there's a toggle under "Import games" that I'd say justifiably creates confusion if it only partly configures Steam syncing.

screenshot from 2018-10-06 21-57-01

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Oct 6, 2018

@moll that's what I'm talking about! I guess I forgot you don't need to login to a Lutris account to get it. But it IS turned OFF for me, and it still syncs! Whether Lutris is running, or starting up. :(

@moll

This comment has been minimized.

Copy link

moll commented Oct 6, 2018

@BloodyIron, yep, and as I described in #962 (comment), it's definitely a bug (or a missing feature, depending on your view :P). If I were you and bothered about it syncing, I'd edit that lutriswindow.py file on my computer to disable the watcher until it gets fixed. :)

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Oct 6, 2018

@moll and what's to prevent an update from undoing that? I'd rather a proper fix get pulled mainline, and I'm hoping this is bringing more attention to this ;P

@tannisroot

This comment has been minimized.

Copy link
Contributor

tannisroot commented Oct 18, 2018

As this is now fixed in master, the issue should be now closed.

@BloodyIron

This comment has been minimized.

Copy link
Author

BloodyIron commented Oct 18, 2018

Is there a target release for this?

@tannisroot

This comment has been minimized.

Copy link
Contributor

tannisroot commented Oct 18, 2018

Yes. 0.4.21 is due by October 20th. You can try it out with a Lutris-git package from AUR or by downloading master as an archive.

@strycore strycore added this to To do in 0.4.21 release Oct 19, 2018

@tannisroot

This comment has been minimized.

Copy link
Contributor

tannisroot commented Oct 19, 2018

So can you close it?

@strycore strycore closed this Oct 19, 2018

0.4.21 release automation moved this from To do to Done Oct 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment