Skip to content

Inconsistent ordering of method definitions #48

@luttje

Description

@luttje

I believe a bug may have been introduced in #42. It causes methods to be ordered inconsistently. Probably because we're now scraping the wiki multiple pages at a time, causing for inconsistent load results between scrapes.

It's most noticeable when you compare recent commit changes: 4af9755 (which show a large amount of changes occurring) to those from before #42. These show only changes to the wiki data, without reordering methods: bd6de32

Additionally this bug causes the following side-effect, where some method definitions are placed before the local ContentIcon = {}:
https://github.com/luttje/glua-api-snippets/blob/4af9755c9657221ea8d6294aace24496aab884e7/library/contenticon.lua

@robotboy655 Would love your feedback, do you recognize an easy fix? I'm thinking a sort somewhere might solve this issue, e.g: in here:

public writePage(page: WikiPage) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions