Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix require to look in bundle *after* filesystem
- Loading branch information
1 parent
4dbbfa2
commit c8da7e7
Showing
1 changed file
with
10 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8da7e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why look in bundle after filesystem, have enough reasons?
HEAD~4 to HEAD broken a lots my projects.
I vote reset --hard head~4. or return the option to the user by come custom policy.
c8da7e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my projects back after use #970
c8da7e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we need to look in bundle after filesystem (only for non bundle modules) is because sometimes there are conflicting versions of a package in both
deps
on disk anddeps
in luvit itself. If require always looks in bundle first, then none of the libraries that are inside luvit can ever be used outside. In particular, I have conflicting versions of http-codec between lit's ecosystem and luvit's builtin libraries.c8da7e7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense.