Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit luvit / lit / luvi to homebrew #787

Closed
creationix opened this Issue Jul 31, 2015 · 13 comments

Comments

Projects
None yet
3 participants
@creationix
Copy link
Member

commented Jul 31, 2015

This is almost done, but there are a few issues blocking us.

Depends on luvit/luvi#113 and luvit/lit#109

A start to the formulae is at https://gist.github.com/tzudot/dd956165cca423d57d71

@creationix

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2015

/cc @tzudot

@kaustavha

This comment has been minimized.

Copy link
Member

commented Jul 31, 2015

+1 for hopefully making installation easier

@creationix

This comment has been minimized.

Copy link
Member Author

commented Jul 31, 2015

Once done, report to Homebrew/legacy-homebrew#42019

@creationix creationix self-assigned this Jul 31, 2015

@creationix

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2015

We're now unblocked on this. Just need to test the new changes a bit, deploy the new lit to production and make a new luvi release.

@creationix

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2015

@tzudot, I fixed the issues in luvi and lit. Can you try to get it working with brew again? Make sure to use at least:

lit: 2.2.4
luvit: 2.4.1
luvi: v2.1.8

I'll make an attempt tomorrow if you don't get to it.

@tzudot

This comment has been minimized.

Copy link

commented Aug 5, 2015

Where can I get the updated tarballs with submodules included? The previous release tarball link is not available anymore.
e.g. https://gist.github.com/tzudot/dd956165cca423d57d71#file-luvi-rb-L4

@creationix

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2015

The latest luvi releases are always found at https://github.com/luvit/luvi/releases/latest.

This particular release is at https://github.com/luvit/luvi/releases/download/v2.1.8/luvi-src-v2.1.8.tar.gz.

The lit zip file is at the same url scheme with the latest being at https://lit.luvit.io/packages/luvit/lit/v2.2.4.zip

@creationix

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2015

  • The luvi-src url now has the version in the filename.
  • Luvi now creates zips with proper CRC32 checksums and so the zips on lit.luvit.io have correct CRCs
  • Packages are snapshotted when published with a frozen set of dependencies, this is used to generate the zip files at lit.luvit.io.
@tzudot

This comment has been minimized.

Copy link

commented Aug 5, 2015

Thank you for pointing me to those URLs, again. The luvi installation went fine but there is an issue with lit, https://gist.github.com/tzudot/b79c4baa67bfb2fac371. I have tried lit installation manually, as well, using the Homebrew formula but it failed. Could you check this error.

@creationix

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2015

@tzudot, ok, I fixed the luvi build to include a proper version when built from tarball. luvit/luvi@e59881b

I've updated the existing tarball so it should work now if you try again. You'll need to update the SHA256 for the luvi tarball.

@creationix

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2015

I went ahead and tried to finish this myself as can be seen in the homebrew PR above. It does seem to work fine, but I'm unsure if we should stick to the official luvit build (static dependencies) or the homebrew style (shared dependencies). Luvi can be built either way.

@creationix creationix closed this Aug 5, 2015

@creationix creationix removed the in progress label Aug 5, 2015

@tzudot

This comment has been minimized.

Copy link

commented Aug 6, 2015

Cool 👍🏽, Homebrew now has a working luvit formula from the core team. I'll try out building/using luvit ( and depending packages too? ) using Homebrew dependencies, and look out for any repercussions of this process.

@creationix

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2015

I do know of at least one issue with the homebrew version. Possible solutions are discussed at luvit/lit#115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.