Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing handle increment on watcher creation #410

Merged
merged 1 commit into from Sep 9, 2013

Conversation

cehoffman
Copy link
Contributor

This fixes issue #367 with the suggested change.

@bnoordhuis
Copy link
Contributor

I'm not a maintainer but I'll make a suggestion anyway: maybe add a regression test?

@cehoffman
Copy link
Contributor Author

You'er right there probably should be. I just needed the fix quick, so
thought I'd help in reducing steps to get it in.

On Apr 8, 2013, at 6:20 AM, Ben Noordhuis notifications@github.com wrote:

I'm not a maintainer but I'll make a suggestion anyway: maybe add a
regression test?


Reply to this email directly or view it on
GitHubhttps://github.com//pull/410#issuecomment-16044971
.

@creationix
Copy link
Member

@bnoordhuis would you like commit access?

rphillips added a commit that referenced this pull request Sep 9, 2013
Fix missing handle increment on watcher creation
@rphillips rphillips merged commit fe01790 into luvit:master Sep 9, 2013
zhaozg pushed a commit to zhaozg/luvit that referenced this pull request Apr 2, 2019
Fix missing handle increment on watcher creation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants