From 8d018c62db52c948f8ee4a041424b614818da526 Mon Sep 17 00:00:00 2001 From: SzabolcsGergely Date: Fri, 6 May 2022 22:29:53 +0300 Subject: [PATCH 1/2] Update FW; change behavior of stereo rectification based on stereo camera FOV; deprecate setFocalLengthFromCalibration --- depthai-core | 2 +- src/pipeline/NodeBindings.cpp | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/depthai-core b/depthai-core index 6b9e15ea3..396bc6f6a 160000 --- a/depthai-core +++ b/depthai-core @@ -1 +1 @@ -Subproject commit 6b9e15ea3b71dece9dd92891813d30f16f374fb2 +Subproject commit 396bc6f6aa66dbcb002ebeb0ce072489f853ed06 diff --git a/src/pipeline/NodeBindings.cpp b/src/pipeline/NodeBindings.cpp index 4a69fbb33..08b214708 100644 --- a/src/pipeline/NodeBindings.cpp +++ b/src/pipeline/NodeBindings.cpp @@ -916,7 +916,13 @@ void NodeBindings::bind(pybind11::module& m, void* pCallstack){ }, DOC(dai, node, StereoDepth, getMaxDisparity)) .def("setPostProcessingHardwareResources", &StereoDepth::setPostProcessingHardwareResources, DOC(dai, node, StereoDepth, setPostProcessingHardwareResources)) .def("setDefaultProfilePreset", &StereoDepth::setDefaultProfilePreset, DOC(dai, node, StereoDepth, setDefaultProfilePreset)) - .def("setFocalLengthFromCalibration", &StereoDepth::setFocalLengthFromCalibration, DOC(dai, node, StereoDepth, setFocalLengthFromCalibration)) + .def("setFocalLengthFromCalibration", [](StereoDepth& s, bool focalLengthFromCalibration){ + PyErr_WarnEx(PyExc_DeprecationWarning, "setFocalLengthFromCalibration is deprecated. Default value is true.", 1); + HEDLEY_DIAGNOSTIC_PUSH + HEDLEY_DIAGNOSTIC_DISABLE_DEPRECATED + return s.setFocalLengthFromCalibration(focalLengthFromCalibration); + HEDLEY_DIAGNOSTIC_POP + }, DOC(dai, node, StereoDepth, setFocalLengthFromCalibration)) .def("useHomographyRectification", &StereoDepth::useHomographyRectification, DOC(dai, node, StereoDepth, useHomographyRectification)) ; // ALIAS From 8e4e5d995e43fdfc1d90f3d17dd6e8a19c9f58a4 Mon Sep 17 00:00:00 2001 From: SzabolcsGergely Date: Fri, 6 May 2022 23:02:40 +0300 Subject: [PATCH 2/2] Update core --- depthai-core | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/depthai-core b/depthai-core index 396bc6f6a..9c0bdbf91 160000 --- a/depthai-core +++ b/depthai-core @@ -1 +1 @@ -Subproject commit 396bc6f6aa66dbcb002ebeb0ce072489f853ed06 +Subproject commit 9c0bdbf91202f3d84848ef38710636916973cc1a