Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Depth Modes: Subpixel, LR-check, extended-disparity support #163

Closed
3 tasks done
Luxonis-Brandon opened this issue Jul 27, 2020 · 5 comments
Closed
3 tasks done
Labels
enhancement New feature or request

Comments

@Luxonis-Brandon
Copy link
Contributor

Luxonis-Brandon commented Jul 27, 2020

Start with the why:

The additional depth modes available in our framework are useful in certain scenarios, including:

  • Supporting closer-in minimum depth (by a factor of 2): Extended disparity
  • Eliminating shadowing from running disparity in only one direction: left/right check (runs disparity in both directions)
  • Allowing further maximum distance, and better accuracy w/in given range: subpixel support

Move to the how:

Analyze the memory/resource use of enabling these modes through the API, and implement such that limits are placed on other resources appropriately (e.g. fewer SHAVES available for neural compute).

Move to the what:

Support the following additional depth modes:

  • Subpixel
  • LR-check
  • Extended disparity
@Luxonis-Brandon Luxonis-Brandon added the enhancement New feature or request label Jul 27, 2020
@Luxonis-Brandon
Copy link
Contributor Author

Luxonis-Brandon commented Aug 18, 2020

Initial LR-check implementation is in #178

@Luxonis-Brandon
Copy link
Contributor Author

And see #184 for more of the why of what subpixel is useful for.

@Luxonis-Brandon
Copy link
Contributor Author

Luxonis-Brandon commented Nov 11, 2020

We have an initial implementation of this now, including a point-cloud projector: https://github.com/luxonis/depthai-experiments#gen2-subpixel-and-lr-check-disparity-depth-here
Go to the repo depthai-experiments , check out the branch gen2_stereo and run:

cd gen2-camera-demo
python3 -m pip install -r requirements.txt
python3 main.py 

It is configured with LRcheck + Subpixel by default.
I will also add command line options, but for now please edit the script to change the config:

lrcheck  = True 
extended = False
subpixel = True 

Note that as of now there is no median filtering when any of the lrcheck, subpixel, or extended disparity are enabled. So that is why it looks a bit grainy.
And there’s some error when doing the point cloud projection where a bunch of valid depth points (maybe 1/2 of them?) don’t get projected. So the quality is actually better than what is shown here.

@Luxonis-Brandon
Copy link
Contributor Author

And here is an example of my floor with subpixel and LR check enabled:
image
And side view of a face with shelves in the background for subpixel and LR check enabled:
image

@Luxonis-Brandon
Copy link
Contributor Author

image

jdavidberger pushed a commit to constructiverealities/depthai that referenced this issue May 26, 2022
* Bug fix

* Fixing negative

* Updated device side fix for signs

* Additinal checks

* Fixed styling

* updated FW to develop:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant