Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harris Filtering Support #248

Closed
Luxonis-Brandon opened this issue Oct 20, 2020 · 6 comments
Closed

Harris Filtering Support #248

Luxonis-Brandon opened this issue Oct 20, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@Luxonis-Brandon
Copy link
Contributor

Start with the why:

Corner detection (Harris corner filtering) is often useful in a variety of CV/AI pipelining usecases and DepthAI has hardware which allows hardware acceleration of this CV function.

Move to the how:

Implement Harris Filtering as a node in the Gen2 pipeline builder (#136).

Move to the what:

Support Harris Filtering as a Gen2 node.

@Luxonis-Brandon Luxonis-Brandon added enhancement New feature or request Gen2 labels Oct 20, 2020
@eric-schleicher
Copy link

+1 for this getting prioritized sooner than later.

@SzabolcsGergely
Copy link
Collaborator

This is now possible on luxonis/depthai-python#317
Either SHI_THOMASI or HARRIS can be selected for feature detection.

featureTracker->initialConfig.setAlgorithmType(dai::FeatureTrackerConfigData::AlgorithmType::CORNER_DETECTION);
featureTracker->initialConfig.setCornerDetector(dai::FeatureTrackerConfigData::CornerDetector::HARRIS);

@Luxonis-Brandon Luxonis-Brandon moved this from Roadmap to In progress in Gen2 Phase I Delivery Jul 22, 2021
@asa
Copy link

asa commented Jul 23, 2021

Testing this with dai::FeatureTrackerConfigData::CornerDetector::SHI_THOMASI doesn't succeed. The first few frames of tracks show up when printing, but then no new tracks appear. Sometimes it starts at the beginning for a few frames, then ends for a while, then starts back up after 10 seconds or so. Inconsistent.

@asa
Copy link

asa commented Jul 23, 2021

After working with it more it appears there is a temporal filter on the quantity that are on screen at any one time and they are slowly added, one at a time till tracking a few hundred on an 800_P frame in my environment. They do look cleaner than the harris corners. Nice!

@asa
Copy link

asa commented Jul 23, 2021

Well, that might have just been because I was running the Left tracker with SHI_THOMASI and the right one with HARRIS for comparison. Setting them both to SHI_THOMASI seems to solve the issue. Sorry for the noise!

@SzabolcsGergely SzabolcsGergely moved this from In progress to Done in Gen2 Phase I Delivery Aug 10, 2021
@SzabolcsGergely
Copy link
Collaborator

Implemented in: luxonis/depthai-python#317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

4 participants