Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_BaseImputer: moves to generic tests, adds a notfittederror test #180

Merged
merged 2 commits into from
Mar 5, 2024
Merged

test_BaseImputer: moves to generic tests, adds a notfittederror test #180

merged 2 commits into from
Mar 5, 2024

Conversation

TommyMatthews
Copy link
Contributor

No description provided.

davidhopkinson26
davidhopkinson26 previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@davidhopkinson26 davidhopkinson26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Nice to see the process of moving tests to the new structure is so simple!

@TommyMatthews TommyMatthews merged commit 5fdbc00 into main Mar 5, 2024
1 check passed
@davidhopkinson26 davidhopkinson26 deleted the feature/base_imputer_generic_tests branch March 21, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhopkinson26 davidhopkinson26 davidhopkinson26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TommyMatthews @davidhopkinson26