improves performance on the i80 bus.

Author: kdschlosser

api_drivers/common_api_drivers/display/st7789/_st7789_init.py

@@ -2,13 +2,13 @@
 from micropython import const  # NOQA
 
 import lvgl as lv  # NOQA
+import lcd_bus
 
 
 _SWRESET = const(0x01)
 _SLPOUT = const(0x11)
 _MADCTL = const(0x36)
 _COLMOD = const(0x3A)
-_IFMODE = const(0xB0)
 _PORCTRL = const(0xB2)
 _GCTRL = const(0xB7)
 _VCOMS = const(0xBB)
@@ -26,6 +26,9 @@
 _DISPON = const(0x29)
 _NORON = const(0x13)
 
+_RAMCTRL = const(0xB0)
+_RGB565SWAP = const(0x08)
+
 
 def init(self):
     param_buf = bytearray(14)
@@ -53,9 +56,16 @@ def init(self):
     param_buf[1] = 0x82
     self.set_params(0xB6, param_mv[:2])
 
-    # param_buf[0] = 0x00
-    # param_buf[1] = 0xE0
-    # self.set_params(_IFMODE, param_mv[:2])
+    # sets swapping the bytes at the hardware level.
+
+    if (
+        self._rgb565_byte_swap and
+        isinstance(self._data_bus, lcd_bus.I80Bus) and
+        self._data_bus.get_lane_count() == 8
+    ):
+        param_buf[0] = 0x00
+        param_buf[1] = 0xF0 | _RGB565SWAP
+        self.set_params(_RAMCTRL, param_mv[:2])
 
     color_size = lv.color_format_get_size(self._color_space)
     if color_size == 2:  # NOQA

api_drivers/common_api_drivers/display/st7789/st7789.py

@@ -1,5 +1,6 @@
 from micropython import const  # NOQA
 import display_driver_framework
+import lcd_bus
 
 
 STATE_HIGH = display_driver_framework.STATE_HIGH
@@ -20,7 +21,62 @@
 class ST7789(display_driver_framework.DisplayDriver):
     _ORIENTATION_TABLE = (
         0x0,
-        _MADCTL_MV | _MADCTL_MY,
+        _MADCTL_MV | _MADCTL_MX,
         _MADCTL_MY | _MADCTL_MX,
-        _MADCTL_MV | _MADCTL_MX
+        _MADCTL_MV | _MADCTL_MY
     )
+
+    def __init__(
+        self,
+        data_bus,
+        display_width,
+        display_height,
+        frame_buffer1=None,
+        frame_buffer2=None,
+        reset_pin=None,
+        reset_state=STATE_HIGH,
+        power_pin=None,
+        power_on_state=STATE_HIGH,
+        backlight_pin=None,
+        backlight_on_state=STATE_HIGH,
+        offset_x=0,
+        offset_y=0,
+        color_byte_order=BYTE_ORDER_RGB,
+        color_space=lv.COLOR_FORMAT.RGB888,  # NOQA
+        rgb565_byte_swap=False,
+    ):
+
+        if color_space != lv.COLOR_FORMAT.RGB565:
+            rgb565_byte_swap = False
+
+        self._rgb565_byte_swap = rgb565_byte_swap
+
+        if (
+            isinstance(data_bus, lcd_bus.I80Bus) and
+            data_bus.get_lane_count() == 8
+        ):
+            rgb565_byte_swap = False
+
+        super().__init__(
+            data_bus=data_bus,
+            display_width=display_width,
+            display_height=display_height,
+            frame_buffer1=frame_buffer1,
+            frame_buffer2=frame_buffer2,
+            reset_pin=reset_pin,
+            reset_state=reset_state,
+            power_pin=power_pin,
+            power_on_state=power_on_state,
+            backlight_pin=backlight_pin,
+            backlight_on_state=backlight_on_state,
+            offset_x=offset_x,
+            offset_y=offset_y,
+            color_byte_order=color_byte_order,
+            color_space=color_space,  # NOQA
+            rgb565_byte_swap=rgb565_byte_swap,
+            _cmd_bits=8,
+            _param_bits=8,
+            _init_bus=True
+        )
+
+

api_drivers/common_api_drivers/display/st7796/st7796.py

@@ -40,8 +40,8 @@ class ST7796(display_driver_framework.DisplayDriver):
     # We just have to tell lvgl that we want to use
 
     _ORIENTATION_TABLE = (
-        _MADCTL_MX,
-        _MADCTL_MV | _MADCTL_MY | _MADCTL_MX,
-        _MADCTL_MY,
-        _MADCTL_MV
+        0x0,
+        _MADCTL_MV | _MADCTL_MX,
+        _MADCTL_MY | _MADCTL_MX,
+        _MADCTL_MV | _MADCTL_MY
     )

ext_mod/lcd_bus/esp32_src/i80_bus.c

@@ -55,7 +55,6 @@
             ARG_dc_data_high,
             ARG_cs_active_high,
             ARG_reverse_color_bits,
-            ARG_swap_color_bytes,
             ARG_pclk_active_low,
             ARG_pclk_idle_low,
         };
@@ -87,7 +86,6 @@
             { MP_QSTR_dc_data_high,       MP_ARG_BOOL | MP_ARG_KW_ONLY,  { .u_bool = true   } },
             { MP_QSTR_cs_active_high,     MP_ARG_BOOL | MP_ARG_KW_ONLY,  { .u_bool = false   } },
             { MP_QSTR_reverse_color_bits, MP_ARG_BOOL | MP_ARG_KW_ONLY,  { .u_bool = false   } },
-            { MP_QSTR_swap_color_bytes,   MP_ARG_BOOL | MP_ARG_KW_ONLY,  { .u_bool = false   } },
             { MP_QSTR_pclk_active_low,    MP_ARG_BOOL | MP_ARG_KW_ONLY,  { .u_bool = false   } },
             { MP_QSTR_pclk_idle_low,      MP_ARG_BOOL | MP_ARG_KW_ONLY,  { .u_bool = false   } }
         };
@@ -148,7 +146,6 @@
         self->panel_io_config.dc_levels.dc_data_level = (unsigned int)args[ARG_dc_data_high].u_bool;
         self->panel_io_config.flags.cs_active_high = (unsigned int)args[ARG_cs_active_high].u_bool;
         self->panel_io_config.flags.reverse_color_bits = (unsigned int)args[ARG_reverse_color_bits].u_bool;
-        self->panel_io_config.flags.swap_color_bytes = (unsigned int)args[ARG_swap_color_bytes].u_bool;
         self->panel_io_config.flags.pclk_active_neg = (unsigned int)args[ARG_pclk_active_low].u_bool;
         self->panel_io_config.flags.pclk_idle_low = (unsigned int)args[ARG_pclk_idle_low].u_bool;
 
@@ -182,7 +179,6 @@
         printf("dc_data_level=%d\n", self->panel_io_config.dc_levels.dc_data_level);
         printf("cs_active_high=%d\n", self->panel_io_config.flags.cs_active_high);
         printf("reverse_color_bits=%d\n", self->panel_io_config.flags.reverse_color_bits);
-        printf("swap_color_bytes=%d\n", self->panel_io_config.flags.swap_color_bytes);
         printf("pclk_active_neg=%d\n", self->panel_io_config.flags.pclk_active_neg);
         printf("pclk_idle_low=%d\n", self->panel_io_config.flags.pclk_idle_low);
     #endif
@@ -202,11 +198,10 @@
     #endif
 
         mp_lcd_i80_bus_obj_t *self = (mp_lcd_i80_bus_obj_t *)obj;
+        self->rgb565_byte_swap = false;
 
-        if (bpp == 16) {
-            self->rgb565_byte_swap = rgb565_byte_swap;
-        } else {
-            self->rgb565_byte_swap = false;
+        if (rgb565_byte_swap && bpp == 16) {
+            self->panel_io_config.flags.swap_color_bytes = 1;
         }
 
         self->panel_io_config.lcd_cmd_bits = (int)cmd_bits;