Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(span) Add missing spangroup functions #2379

Merged

Conversation

ahoenerBE
Copy link
Contributor

@ahoenerBE ahoenerBE commented Jul 16, 2021

Description of the feature or fix

Adds 2 functions:

  • lv_spangroup_get_child -- Gets a span stored in the spangroup linkedlist, returns span pointer
  • lv_spangroup_get_child_cnt -- Gets the total number of spans in the spangroup, returns uint

Tested in LVGL sim using lv_example_span. I added variables for every span added (e.g. span1, span2, etc) and checked them with the following code after they were all added.

Gist link for my test example (works in LVGL sim)

Updated lv_span docs

Fixes #2375

Checkpoints

@ahoenerBE ahoenerBE force-pushed the feature/spangroup-child-functions branch from ddf93d3 to 60c6bcb Compare July 16, 2021 15:59
@kisvegabor
Copy link
Member

Looks good to me. If @guoweilkd also agrees I merge it.

@embeddedt embeddedt changed the title fix(span) Add missing spangroup functions feat(span) Add missing spangroup functions Jul 16, 2021
Added functions `lv_spangroup_get_child` and `lv_spangroup_get_child_cnt` to retrieve child spans and child count from the spangroup.

Fixes: lvgl#2375
@ahoenerBE ahoenerBE force-pushed the feature/spangroup-child-functions branch from 60c6bcb to 5956fb6 Compare July 16, 2021 17:03
@ahoenerBE
Copy link
Contributor Author

ahoenerBE commented Jul 16, 2021

Changed commit message from fix to feat as per embeddedt

@guoweilkd
Copy link
Contributor

Looks good to me. If @guoweilkd also agrees I merge it.

Looks good to me.

@embeddedt embeddedt merged commit d041191 into lvgl:master Jul 19, 2021
@embeddedt
Copy link
Member

Thank you; merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functions to get span children once added to spangroup
4 participants