fix(chart) fixed point-following cursor during vertical scroll in charts #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embeddedt
approved these changes
Jul 23, 2021
|
I was also happy to see the simulator being used 🙂 Merging, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
Here's the issue(cursor linked to a point not following the cursor during vertical scrolling):
https://sim.lvgl.io/v8.1/micropython/ports/javascript/index.html?script_startup=https://raw.githubusercontent.com/lvgl/lvgl/6d8799fbbfb1477ad2e0887644fb4cd900817199/examples/header.py&script=https://raw.githubusercontent.com/lvgl/lvgl/6d8799fbbfb1477ad2e0887644fb4cd900817199/examples/widgets/chart/lv_example_chart_1.py&script_direct=7e3cdfc917ff6519147fd3877ac9c7dd764be780
After following the cursor drawing code I ended up at the same four lines I just pushed this morning.
p_out->y -= lv_obj_get_scroll_top(obj);was missing so the vertical scroll was not accounted for.