Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs) add static keyword to driver declaration #2452

Merged
merged 1 commit into from Aug 13, 2021
Merged

fix(docs) add static keyword to driver declaration #2452

merged 1 commit into from Aug 13, 2021

Conversation

fvanroie
Copy link
Contributor

Add missing static keyword to disp_drv and indev_drv declarations in the examples

Description of the feature or fix

Fix for this forum post:

It seems you have forgotten to place the static keyword before the “lv_disp_drv_t disp_drv;” in the get started section of the V8 document (Page 194). It is misleading for beginners.

Checkpoints

Add missing static keyword to disp_drv and indev_drv declarations in the examples
Copy link
Member

@embeddedt embeddedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! That explains why users are still not adding this flag... they are probably all reading this page. 😆

@embeddedt embeddedt merged commit e8c1670 into lvgl:master Aug 13, 2021
embeddedt pushed a commit that referenced this pull request Aug 13, 2021
Add missing static keyword to disp_drv and indev_drv declarations in the examples
@fvanroie
Copy link
Contributor Author

fvanroie commented Aug 13, 2021

Not sure of this change will affect the v8 (minor) and v8.0 branches too???
It might needs some backports to those branches too as not everyone is consulting the v8.1 docs yet.

Edit: I just checked and all versions seem to have received the update. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants