Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal for lv_obj_swap() function #2461

Merged
merged 3 commits into from Aug 18, 2021
Merged

Conversation

Karijn
Copy link
Contributor

@Karijn Karijn commented Aug 17, 2021

Description of the feature or fix

A clear and concise description of what the bug or new feature is.

Checkpoints

@Karijn Karijn closed this Aug 17, 2021
Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you closed the PR? It looked good in general, I had only a few minor comments.

src/core/lv_obj_tree.c Outdated Show resolved Hide resolved
src/core/lv_obj_tree.c Show resolved Hide resolved
@@ -101,6 +101,14 @@ void lv_obj_move_foreground(struct _lv_obj_t * obj);
*/
void lv_obj_move_background(struct _lv_obj_t * obj);

/**
* Swap two objects within the same parent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should work with different parents too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. It seems only this comment should be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@kisvegabor kisvegabor reopened this Aug 17, 2021
@Karijn
Copy link
Contributor Author

Karijn commented Aug 17, 2021

review issues applied

@Karijn Karijn closed this Aug 17, 2021
@embeddedt embeddedt reopened this Aug 17, 2021
@embeddedt
Copy link
Member

It seems that you keep closing it by accident; not sure why. You may be clicking "Close with comment" instead of "Comment"?

@kisvegabor
Copy link
Member

Looks good, thank you very much!

I merge it.

@kisvegabor kisvegabor merged commit 9a1f7f2 into lvgl:master Aug 18, 2021
Karijn added a commit to Karijn/lvgl that referenced this pull request Sep 2, 2021
… as inline functions now calling lv_obj_move_to_index(obj, index).

- lv_obj_swap(obj1, obj2) added. (lvgl#2461)
kisvegabor pushed a commit that referenced this pull request Sep 5, 2021
…ild_id(obj) to lv_obj_get_index(obj) (#2514)

* - renamed lv_obj_get_id(obj) to lv_obj_get_index(obj).

- added lv_obj_move_to_index(obj, index).

* automatic review comment fixed

* removed unused variable

* review issue

* restored deprecated function in header, otherwise Build Micropython with LVGL submodule / build (pull_request)  failes

* moved deprecated lv_obj_get_child_id() back to lv_obj_tree.h, otherwise Micropython will not build

* inline function did not work

* made deprecated function 'static inline'

* and now also inline

* move static inline function to lv_api_map.h again

* removed lv_obj_move_up/down

* changed log to warning for deprecated function

* redefined lv_obj_move_foreground(obj) and lv_obj_move_background(obj) as inline functions now calling lv_obj_move_to_index(obj, index).

- lv_obj_swap(obj1, obj2) added. (#2461)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants