Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware Accelerated Rendering by SDL2 #2484

Merged
merged 96 commits into from Sep 16, 2021
Merged

Conversation

mariotaku
Copy link
Contributor

@mariotaku mariotaku commented Aug 23, 2021

Description of the feature or fix

This is a work-in-progress PR, to achieve part of #2058.
TODOs:

  • Profiling of slow calls and RAM/VRAM usage - complex drawing is performed by CPU yet
  • Name convention and file structure refactoring
  • License issue - external sources has been marked in gpu/sdl/README.md
  • Proper comments and docs

Checkpoints

@kisvegabor
Copy link
Member

kisvegabor commented Aug 24, 2021

Great work! So all the rendering is handled by SDL.

I haven't checked it line by line but it seems all the draw functions are implemented except triangle and polygon drawing, right?

I couldn't find lv_gpu_draw_cache_get for letters. Is it intentional?
(Found the "caching" here).

@mariotaku
Copy link
Contributor Author

@kisvegabor Drawing of text are implemented very early and I'll adjust it to use lv_gpu_cache as well.

@rzr
Copy link
Contributor

rzr commented Aug 25, 2021

This change is desirable thx

src/draw/lv_draw_arc.c Outdated Show resolved Hide resolved
@rzr rzr mentioned this pull request Sep 9, 2021
@mariotaku
Copy link
Contributor Author

There are still many things I want to do, but to make this available sooner I'll do in future PRs.

@mariotaku mariotaku marked this pull request as ready for review September 10, 2021 07:23
Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only two minor remarks.

src/lv_conf_internal.h Outdated Show resolved Hide resolved
src/gpu/sdl/lv_gpu_sdl_utils.c Show resolved Hide resolved
@mariotaku
Copy link
Contributor Author

@kisvegabor Thank you. I have made another round of checking, those files should have been all updated.

@kisvegabor
Copy link
Member

Thank you, looks good to me.

Let me know if I can marge it.

@mariotaku
Copy link
Contributor Author

@kisvegabor I think it can be merged :)

@kisvegabor
Copy link
Member

🥁 🥁 🥁

Merging! 🙂

Thank you very much for your great work. It's a very important step as now we have the concept to integrate higher level GPUs.
I still have an idea about further abstraction but I'll open an issue for it soon.

@kisvegabor kisvegabor merged commit efc5bb4 into lvgl:master Sep 16, 2021
@mariotaku mariotaku deleted the sdl-renderer branch September 16, 2021 16:42
@C47D C47D mentioned this pull request Sep 24, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants