Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lvgl interface target for micropython #2529

Merged
merged 2 commits into from Sep 6, 2021

Conversation

eudoxos
Copy link
Contributor

@eudoxos eudoxos commented Sep 5, 2021

The CMake interface target for micropython is now working. Non-micropython builds are not affected.

@amirgon
Copy link
Contributor

amirgon commented Sep 5, 2021

So this assumes Micropython-ESP32 migrates to usermod right?
In current state this change would break the ESP32 port.

@eudoxos
Copy link
Contributor Author

eudoxos commented Sep 5, 2021

So this assumes Micropython-ESP32 migrates to usermod right?

Quite on the contrary, EPS32 and Zephyr should not be affected in the slightest.

I wanted to add indentation to CMakeLists.txt to make that clear but found it too intrusive. It is like this:

if(ESP_PLATFORM)
# ... [unintended]
elseif(ZEPHYR_BASE)
# ... [unintended]
else()
    # [here is where my changes start]
    # ... 
    if(MICROPY_DIR)
        # ...
    else(MICROPY_DIR)
        # ...
    endif(MICROPY_DIR)
endif()

@amirgon
Copy link
Contributor

amirgon commented Sep 5, 2021

Quite on the contrary, EPS32 and Zephyr should not be affected in the slightest.

Got it. Thanks for the clarification!

@kisvegabor
Copy link
Member

I can't judge if these changes are correct, so please let me know if it's ready to merge.

@amirgon
Copy link
Contributor

amirgon commented Sep 5, 2021

I can't judge if these changes are correct, so please let me know if it's ready to merge.

Looks good to me, although I can't test this since it's RPi specific change.

@kisvegabor
Copy link
Member

Thank you, merging.

@kisvegabor kisvegabor merged commit 715d580 into lvgl:master Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants