Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lv example list 2 #2545

Merged
merged 6 commits into from
Sep 13, 2021
Merged

Add lv example list 2 #2545

merged 6 commits into from
Sep 13, 2021

Conversation

Karijn
Copy link
Contributor

@Karijn Karijn commented Sep 9, 2021

Description of the feature or fix

A clear and concise description of what the bug or new feature is.

Checkpoints

@Karijn
Copy link
Contributor Author

Karijn commented Sep 9, 2021

in the c example all command buttons are removed from the group using
lv_group_remove_obj(btn);

btn = lv_list_add_btn(list2, LV_SYMBOL_SHUFFLE, "Shuffle");
lv_obj_add_event_cb(btn, event_handler_swap, LV_EVENT_ALL, NULL);
lv_group_remove_obj(btn);

i couldn't find a MP version of lv_group_remove_obj()

@amirgon
Copy link
Contributor

amirgon commented Sep 9, 2021

i couldn't find a MP version of lv_group_remove_obj()

Did you try lv.group_remove_obj(btn)?

It's not a member of lv.group_t since lv_group_remove_obj doesn't receive lv_group_t* as its first argument. I think it could be nicer if it did.

@kisvegabor
Copy link
Member

Looks good to me. Is it ready to merge?

@Karijn
Copy link
Contributor Author

Karijn commented Sep 13, 2021

as far as i know, its ready and complete

@kisvegabor
Copy link
Member

Merging then, thank you! 🙂

@kisvegabor kisvegabor merged commit 953d9fb into lvgl:master Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants