Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fsdrv): skip the path format if LV_FS_xxx_PATH not defined #2726

Merged
merged 1 commit into from Oct 27, 2021

Conversation

xiaoxiang781216
Copy link
Collaborator

Description of the feature or fix

to save the stack space and fix some minor code style issue

Checkpoints

to save the stack space and fix some minor code style issue

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@@ -27,7 +24,7 @@
* STATIC PROTOTYPES
**********************/

static bool is_dots_name(LPCSTR name);
static bool is_dots_name(const char * name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MouriNaruto please take a look at this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kisvegabor In Windows SDK, LPCSTR is const char*. So it's OK.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kisvegabor could you merge PR? @MouriNaruto confirm that the change is good for Windows too.

@kisvegabor kisvegabor merged commit ec2be7e into lvgl:master Oct 27, 2021
@kisvegabor
Copy link
Member

Merged, thanks!

@xiaoxiang781216 xiaoxiang781216 deleted the path2 branch October 27, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants