Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some errors in bidi algorithm when displaying arabic #2777

Merged
merged 4 commits into from Nov 10, 2021

Conversation

Bluelongshirt
Copy link
Contributor

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good in general, but please fix some formatting issues.

@@ -465,6 +469,16 @@ static lv_base_dir_t get_next_run(const char * txt, lv_base_dir_t base_dir, uint
pos_conv_i++;
next_dir = lv_bidi_get_letter_dir(letter);
if(next_dir == LV_BASE_DIR_NEUTRAL) next_dir = bracket_process(txt, i, max_len, letter, base_dir);


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these extra empty lines.

src/misc/lv_bidi.c Outdated Show resolved Hide resolved
@Bluelongshirt
Copy link
Contributor Author

I am sorry that there is a problem with the format of the file, I fixed the problem, you see if it is correct

@kisvegabor
Copy link
Member

Looks good, thank you!

@kisvegabor kisvegabor merged commit 9113b9d into lvgl:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants