Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(refr): avoid swapping buffers every area in direct mode #2867

Merged
merged 3 commits into from Dec 3, 2021

Conversation

gh2o
Copy link
Contributor

@gh2o gh2o commented Dec 2, 2021

Description of the feature or fix

When using direct_mode and 2 buffers, direct mode is not useful because half of the invalidated areas are drawn to buf1 and half are drawn to buf2. This PR ensures that the buffer swap does not occur until a given buffer is fully redrawn.

Checkpoints

  • Follow the styling guide
  • Run code-format.py from the scripts folder. astyle needs to be installed.
  • Update the documentation

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

I've just added an extra comment.

src/core/lv_refr.c Show resolved Hide resolved
src/core/lv_refr.c Outdated Show resolved Hide resolved
@kisvegabor kisvegabor merged commit 222af5a into lvgl:master Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants