Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasmota introduction #2874

Merged
merged 7 commits into from Dec 3, 2021
Merged

Tasmota introduction #2874

merged 7 commits into from Dec 3, 2021

Conversation

s-hadinger
Copy link
Contributor

Description of the feature or fix

Introduction of Tasmota+Berry in the LVGL documentation with a quick start on M5Stack devices in less than 10 minutes

Checkpoints

  • Follow the styling guide
  • Run code-format.py from the scripts folder. astyle needs to be installed.
  • Update the documentation

Copy link
Member

@kisvegabor kisvegabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you very much! Only a minor comment above.

docs/get-started/index.md Outdated Show resolved Hide resolved
@kisvegabor
Copy link
Member

kisvegabor commented Dec 3, 2021

Sorry, I added the suggestion to the wrong point. Now it should be fine. I also corrected the numbers of the enumeration.

Do you agree it's ok this way?

@s-hadinger
Copy link
Contributor Author

Yes, still I'm confused that the link for item 6. points to itself. Wouldn't it be better to mention the different platform specific tutorials here?

@kisvegabor
Copy link
Member

True, I've added a subsection for platform specific links and pointed the link in step 6 to that section.

It's still not perfect but at least makes a little more sense.

@s-hadinger
Copy link
Contributor Author

Sounds good to me!

@kisvegabor
Copy link
Member

kisvegabor commented Dec 3, 2021

Great, merging! Than you very much!

@kisvegabor kisvegabor merged commit d379804 into lvgl:master Dec 3, 2021
@kisvegabor
Copy link
Member

@s-hadinger s-hadinger mentioned this pull request Dec 3, 2021
3 tasks
@xiaoxiang781216
Copy link
Collaborator

@s-hadinger should we move berry to binding section instead?
https://docs.lvgl.io/master/get-started/bindings/index.html

@s-hadinger
Copy link
Contributor Author

Hi, sorry. Yes. Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants