Skip to content

Conversation

@kisvegabor
Copy link
Member

Description of the feature or fix

  • Ensure that at least one image/arc/etc is added
  • Measure the flush wait time too

Please test and review it in as many cases as possible. Is it looks good and the reported data is consistent, I'll migrate the same idea to v8.

@nicusorcitu @zjanosy @KamranAghlami @espzav

Notes

PGNetHun
PGNetHun previously approved these changes Feb 2, 2024
@espzav
Copy link

espzav commented Feb 2, 2024

For me, it is same for v9.0.0 and this PR. I have problem stucked here:
20240202_120944

I (1065) main_task: Returned from app_main()
E (47233) task_wdt: Task watchdog got triggered. The following tasks/users did not reset the watchdog in time:
E (47233) task_wdt:  - IDLE0 (CPU 0)
E (47233) task_wdt: Tasks currently running:
E (47233) task_wdt: CPU 0: LVGL task
E (47233) task_wdt: CPU 1: IDLE1
E (47233) task_wdt: Print CPU 0 (current core) backtrace


Backtrace: 0x4203AB56:0x3FC9C560 0x4037C2ED:0x3FC9C590 0x42016BC0:0x3FCB9350 0x42015B87:0x3FCB9370 0x420162A9:0x3FCB93A0 0x420224FA:0x3FCB9430 0x42022655:0x3FCB9460 0x4200E23C:0x3FCB9480
0x4203ab56: task_wdt_timeout_handling at C:/WORK/GIT/esp-idf_GitLab/components/esp_system/task_wdt/task_wdt.c:434
 (inlined by) task_wdt_isr at C:/WORK/GIT/esp-idf_GitLab/components/esp_system/task_wdt/task_wdt.c:507

0x4037c2ed: _xt_lowint1 at C:/WORK/GIT/esp-idf_GitLab/components/xtensa/xtensa_vectors.S:1240

0x42016bc0: lv_draw_dispatch at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/draw/lv_draw.c:165

0x42015b87: draw_buf_flush at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/core/lv_refr.c:1001
 (inlined by) refr_area_part at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/core/lv_refr.c:724

0x420162a9: refr_area at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/core/lv_refr.c:650
 (inlined by) refr_invalid_areas at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/core/lv_refr.c:566
 (inlined by) _lv_display_refr_timer at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/core/lv_refr.c:374

0x420224fa: lv_timer_exec at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/misc/lv_timer.c:300 (discriminator 2)
 (inlined by) lv_timer_handler at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/misc/lv_timer.c:105 (discriminator 2)

0x42022655: lv_timer_handler at C:/WORK/GIT/esp-bsp-01/examples/display_lvgl_demos/components/lvgl__lvgl/src/misc/lv_timer.c:71

0x4200e23c: lvgl_port_task at C:/WORK/GIT/esp-bsp-01/components/esp_lvgl_port/src/lvgl9/esp_lvgl_port.c:154

@espzav
Copy link

espzav commented Feb 2, 2024

The next thing that I discovered is: When I used lv_demo_music() and the FPS monitor is disabled (in default), on the last view is "text" instead of FPS value. I didn't see any warning or something like that.

@PGNetHun PGNetHun self-requested a review February 2, 2024 15:47
@kisvegabor
Copy link
Member Author

I've added an important fix to correctly calculate the flush time

@espzav For the stuck at opa layered, please increase LV_MEM_SIZE

I'll look into the music player demo

@kisvegabor
Copy link
Member Author

I merge it now, and will beckport the changes to v8 today.

@kisvegabor kisvegabor merged commit f880cc8 into lvgl:master Feb 5, 2024
@kisvegabor kisvegabor deleted the fix/benchmark branch February 5, 2024 07:42
@PGNetHun
Copy link
Collaborator

PGNetHun commented Feb 5, 2024

@espzav
Copy link

espzav commented Feb 5, 2024

For the stuck at opa layered, please increase LV_MEM_SIZE

Thank you. I had 48 KB. Now, I have 100 KB and it is working.

@kisvegabor
Copy link
Member Author

oh, missing flush_cnt:

Ouch, fixed in #5597.

kisvegabor added a commit that referenced this pull request Feb 5, 2024
kisvegabor added a commit to kisvegabor/lvgl_fork that referenced this pull request Feb 5, 2024
@nicusorcitu
Copy link
Contributor

@cristian-stoica

HongChao6 pushed a commit to HongChao6/lvgl that referenced this pull request Oct 18, 2024
HongChao6 pushed a commit to HongChao6/lvgl that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants