Skip to content

Conversation

@XuNeo
Copy link
Collaborator

@XuNeo XuNeo commented Feb 9, 2024

Description of the feature or fix

Now event dsc is stored in an array by pointer. The pointer is returned to user and can be deleted laster with it.

Notes

Now event dsc is stored in an array by pointer. The pointer is returned to user and can be deleted laster with it.

Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
@kisvegabor
Copy link
Member

The failing test:

/home/runner/work/lvgl/lvgl/tests/src/test_cases/widgets/test_switch.c:71:test_switch_should_not_leak_memory_after_deletion:FAIL: Expected 33527492 to be less than or equal to 33527488

4 byte of memory leak can be due to memory fragmentation too. Especially as the issue is not reported by other tests.

I suggest using TEST_ASSERT_MEM_LEAK_LESS_THAN with 8 byte of threshold.

Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
@XuNeo XuNeo marked this pull request as ready for review February 17, 2024 14:12
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
@XuNeo XuNeo requested review from PGNetHun and kisvegabor February 18, 2024 03:07
@kisvegabor kisvegabor merged commit f5f19ca into lvgl:master Feb 19, 2024
@kisvegabor
Copy link
Member

Thanks!

HongChao6 pushed a commit to HongChao6/lvgl that referenced this pull request Oct 18, 2024
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
HongChao6 pushed a commit to HongChao6/lvgl that referenced this pull request Oct 18, 2024
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Signed-off-by: Xu Xingliang <xuxingliang@xiaomi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants