fix(pxp): fix issues in pxp cache management callback - #5685
Merged
Conversation
fix _invalidate_cache wrong signature in declaration fix _invalidate_cache uses draw_buf as a data buffer fix _invalidate_cache uses unkown DEMO_CleanInvalidateCacheByAddr instead of DCACHE_CleanInvalidateByRange update the *invalidate_cache* functions signature to make draw_buf a pointer to const Signed-off-by: Hatim-Pierre FAZILEABASSE <hatim-pierre.fazileabasse@ingenico.com>
Collaborator
|
Hi, |
Contributor
Author
|
Hi @XuNeo, I added the 'const' because in On CLang this will result in the following warning: And since |
hpfaz
marked this pull request as ready for review
February 19, 2024 11:12
C47D
approved these changes
Feb 19, 2024
XuNeo
approved these changes
Feb 20, 2024
kisvegabor
approved these changes
Feb 22, 2024
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Hatim-Pierre FAZILEABASSE <hatim-pierre.fazileabasse@ingenico.com>
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
Signed-off-by: Hatim-Pierre FAZILEABASSE <hatim-pierre.fazileabasse@ingenico.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
fix
_invalidate_cachewrong signature in declarationfix
_invalidate_cacheusesdraw_bufas a data bufferfix
_invalidate_cacheuses unknownDEMO_CleanInvalidateCacheByAddrinstead ofDCACHE_CleanInvalidateByRangeupdate the
*invalidate_cache*functions signature to makedraw_bufa pointer toconstNotes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.10 needs to be installed) and follow the Code Conventions.