fix(drm): eliminate use of non-existent lv_api_map.h and enable smoke tests#5694
Merged
kisvegabor merged 3 commits intolvgl:masterfrom Feb 22, 2024
Merged
Conversation
c9d9a83 to
c9693a8
Compare
XuNeo
reviewed
Feb 19, 2024
a72d611 to
1c0edbe
Compare
Collaborator
|
Hi, |
1c0edbe to
e4a5d77
Compare
Contributor
Author
Thanks. I think I messed up because I couldn't get your branch to merge cleanly onto mine. But I've resolved the conflicts manually which hopefully should yield the same result. |
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Collaborator
|
I added guard to macros overrides in cmake. Confirmed it compiles. :) |
Signed-off-by: Neo Xu <neo.xu1990@gmail.com>
Contributor
Author
|
Great, thank you! 👍 |
XuNeo
approved these changes
Feb 20, 2024
kisvegabor
approved these changes
Feb 22, 2024
Member
kisvegabor
left a comment
There was a problem hiding this comment.
It's great that DRM is tested now at least by a build test.
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
… tests (lvgl#5694) Signed-off-by: Neo Xu <neo.xu1990@gmail.com> Co-authored-by: Neo Xu <neo.xu1990@gmail.com>
HongChao6
pushed a commit
to HongChao6/lvgl
that referenced
this pull request
Oct 18, 2024
… tests (lvgl#5694) Signed-off-by: Neo Xu <neo.xu1990@gmail.com> Co-authored-by: Neo Xu <neo.xu1990@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the feature or fix
Compiling the DRM display driver currently fails because it uses a non-existent include.
This PR simply removes the include.
I also tried enabling compilation of both the DRM and FBDEV drivers on the CI in this PR.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.10 needs to be installed) and follow the Code Conventions.