-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
refact(vg_lite): abstract common pending release logic #5756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
216fe50 to
258dcf3
Compare
kisvegabor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you add/remove items to the pending arrays, but can't see where you actually use them, i.e. where you do something with the saved items.
It's here: |
|
What I can't see is why is it good to add something to the pending list. When/Where do you read the list, and do something with it? |
Since the cmd buffer of vg-lite only records the address of the image, after submitting the image to the GPU for rendering, we need to prevent the image being rendered from being automatically released by the cache. |
16e6355 to
2d42e20
Compare
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com>
2d42e20 to
4fb8a17
Compare
|
Clear now, thanks! |
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com> Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com>
Signed-off-by: pengyiqiang <pengyiqiang@xiaomi.com> Co-authored-by: pengyiqiang <pengyiqiang@xiaomi.com>
Description of the feature or fix
Generalized delayed release logic.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle version v3.4.10 needs to be installed) and follow the Code Conventions.