Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to get all the keys (aka keySet()) to the Accessible interface #46

Closed
bbossola opened this issue Jul 28, 2013 · 2 comments
Closed

Comments

@bbossola
Copy link
Contributor

@bbossola bbossola commented Jul 28, 2013

The Accessible interface is cool but it lacks a method to programmatic-ally get a list of all the keys, just in case you need to show the configuration in any different way from the basic list mechanism already present

@lviggiano
Copy link
Owner

@lviggiano lviggiano commented Jul 29, 2013

👍 pretty easy, I'll do that asap. I will return a "snapshot" of the keySet, not the keySet itself as returned by Properties.keySet(). I think it should be fine too, and will prevent unchecked modifications (thread safety, etc)

lviggiano added a commit that referenced this issue Jul 29, 2013
in interface Accessible

    Set<String> propertyNames();

This differs from the correspondent method in java.util.Properties
since Properties.propertyNames returns an Enumeration<?> but property
names are required to be Strings. In JDK 1.6 the method
`Set<String> stringPropertyNames()` has been introduced but since
we require JDK 1.5+ support I couldn't just delegate and I had to
reimplement it. So I chosed to implement it with the proper method
signature, even though it doesn't match java.util.Properties
interface.
@lviggiano
Copy link
Owner

@lviggiano lviggiano commented Jul 29, 2013

implemented on master, Accessible.propertyNames()

@lviggiano lviggiano closed this Jul 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.