Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot reload does not work when file name needs to be expanded #50

Closed
bbossola opened this issue Sep 11, 2013 · 6 comments
Closed

Hot reload does not work when file name needs to be expanded #50

bbossola opened this issue Sep 11, 2013 · 6 comments
Assignees

Comments

@bbossola
Copy link
Contributor

@bbossola bbossola commented Sep 11, 2013

The hot reload feature is not working when the file name needs to be expanded, i.e.:
"file:${application.configurationFile}"
or
"file:~/config.properties"

When an absolute file name is present the hotreload will work as expected.

@lviggiano
Copy link
Owner

@lviggiano lviggiano commented Sep 11, 2013

I'll check this asap. This is new highest priority.

Thanks.

@ghost ghost assigned lviggiano Sep 11, 2013
@bbossola
Copy link
Contributor Author

@bbossola bbossola commented Sep 16, 2013

bump :)

@lviggiano
Copy link
Owner

@lviggiano lviggiano commented Sep 16, 2013

I'm looking into this. Last week, I wanted to complete dev on issue #47
now this is on top of the list.

lviggiano added a commit that referenced this issue Sep 18, 2013
@lviggiano
Copy link
Owner

@lviggiano lviggiano commented Sep 18, 2013

Hi Bruno, I wrote a test to reproduce the bug, and it looks to me that it's not reproducible. I suppose that the bug is present in the released version (I'll verify this running the test against the latest released version and let you know), but in master the bug may have been removed with code refactoring already.

Have a look at the test to double check: HotReloadWhenURLContainsVariablesTest.java

lviggiano added a commit that referenced this issue Sep 18, 2013
lviggiano added a commit that referenced this issue Sep 18, 2013
… maintainance branch
@lviggiano
Copy link
Owner

@lviggiano lviggiano commented Sep 18, 2013

Hi @bbossola. I deployed version 1.0.4.1-SNAPSHOT here. If you can confirm the bug is solved for you in this version, I'll release version 1.0.4.1 in the release repository in maven central repository.

As verified, version 1.0.5 is not affected.

@lviggiano
Copy link
Owner

@lviggiano lviggiano commented Sep 18, 2013

1.0.4.1 is released in maven central repository. See here.
Announcement for 1.0.4.1 release is available here.

1.0.5 (current master) is not affected by this bug.

Thanks @bbossola for spotting this bug, for confirming 1.0.4.1-SNAPSHOT was fixed, and for the collaboration.

Closing the bug report.

@lviggiano lviggiano closed this Sep 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.