Hot reload does not work when file name needs to be expanded #50

Closed
bbossola opened this Issue Sep 11, 2013 · 6 comments

Comments

Projects
None yet
2 participants
@bbossola
Contributor

bbossola commented Sep 11, 2013

The hot reload feature is not working when the file name needs to be expanded, i.e.:
"file:${application.configurationFile}"
or
"file:~/config.properties"

When an absolute file name is present the hotreload will work as expected.

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano Sep 11, 2013

Owner

I'll check this asap. This is new highest priority.

Thanks.

Owner

lviggiano commented Sep 11, 2013

I'll check this asap. This is new highest priority.

Thanks.

@ghost ghost assigned lviggiano Sep 11, 2013

@bbossola

This comment has been minimized.

Show comment
Hide comment
@bbossola

bbossola Sep 16, 2013

Contributor

bump :)

Contributor

bbossola commented Sep 16, 2013

bump :)

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano Sep 16, 2013

Owner

I'm looking into this. Last week, I wanted to complete dev on issue #47
now this is on top of the list.

Owner

lviggiano commented Sep 16, 2013

I'm looking into this. Last week, I wanted to complete dev on issue #47
now this is on top of the list.

lviggiano added a commit that referenced this issue Sep 18, 2013

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano Sep 18, 2013

Owner

Hi Bruno, I wrote a test to reproduce the bug, and it looks to me that it's not reproducible. I suppose that the bug is present in the released version (I'll verify this running the test against the latest released version and let you know), but in master the bug may have been removed with code refactoring already.

Have a look at the test to double check: HotReloadWhenURLContainsVariablesTest.java

Owner

lviggiano commented Sep 18, 2013

Hi Bruno, I wrote a test to reproduce the bug, and it looks to me that it's not reproducible. I suppose that the bug is present in the released version (I'll verify this running the test against the latest released version and let you know), but in master the bug may have been removed with code refactoring already.

Have a look at the test to double check: HotReloadWhenURLContainsVariablesTest.java

lviggiano added a commit that referenced this issue Sep 18, 2013

lviggiano added a commit that referenced this issue Sep 18, 2013

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano Sep 18, 2013

Owner

Hi @bbossola. I deployed version 1.0.4.1-SNAPSHOT here. If you can confirm the bug is solved for you in this version, I'll release version 1.0.4.1 in the release repository in maven central repository.

As verified, version 1.0.5 is not affected.

Owner

lviggiano commented Sep 18, 2013

Hi @bbossola. I deployed version 1.0.4.1-SNAPSHOT here. If you can confirm the bug is solved for you in this version, I'll release version 1.0.4.1 in the release repository in maven central repository.

As verified, version 1.0.5 is not affected.

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano Sep 18, 2013

Owner

1.0.4.1 is released in maven central repository. See here.
Announcement for 1.0.4.1 release is available here.

1.0.5 (current master) is not affected by this bug.

Thanks @bbossola for spotting this bug, for confirming 1.0.4.1-SNAPSHOT was fixed, and for the collaboration.

Closing the bug report.

Owner

lviggiano commented Sep 18, 2013

1.0.4.1 is released in maven central repository. See here.
Announcement for 1.0.4.1 release is available here.

1.0.5 (current master) is not affected by this bug.

Thanks @bbossola for spotting this bug, for confirming 1.0.4.1-SNAPSHOT was fixed, and for the collaboration.

Closing the bug report.

@lviggiano lviggiano closed this Sep 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment