New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #184 - have ConfigFactory throw exeption on illegal import maps #185

Merged
merged 2 commits into from Feb 10, 2017

Conversation

Projects
None yet
2 participants
@StFS
Contributor

StFS commented Sep 19, 2016

This PR will ensure that ConfigFactory throws an exception with a message containing the problematic key name if an import map contains either a null key or a null value.

OWNER currently fails when an import map contains a null key or value, this PR simply makes the error message clearer.

StFS added some commits Sep 19, 2016

184: Having ConfigFactory throw an exception including a message that…
… contains the key name when supplying a map with either a null value or a null key.

@lviggiano lviggiano merged commit 54443f3 into lviggiano:master Feb 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@StFS

This comment has been minimized.

Contributor

StFS commented Apr 6, 2017

Fixes #184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment