UTF-8 encoding properties. Resolves #77 #78

Merged
merged 1 commit into from May 23, 2014

Conversation

Projects
None yet
2 participants
@SvetaNesterenko
Contributor

SvetaNesterenko commented May 22, 2014

I would like to contribute to your project and I decided to get started with this issue. I am not sure if I did this right, so I would appreciate any comments.

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 23, 2014

Owner

I think that the implementation is correct. But, a unit test, to prove that
utf-8 encoded properties file are loaded properly is needed. You can add
it, or I will, before merging.
Il 22/mag/2014 21:44 "SvetaNesterenko" notifications@github.com ha
scritto:

I would like to contribute to your project and I decided to get started
with this issue. I am not sure if I did this right, so I would appreciate

any comments.

You can merge this Pull Request by running

git pull https://github.com/SvetaNesterenko/owner utf8-fix

Or view, comment on, or merge it at:

#78
Commit Summary

  • UTF-8 encoding properties. Resolves #77

File Changes

  • M
    owner/src/main/java/org/aeonbits/owner/loaders/PropertiesLoader.javahttps://github.com/lviggiano/owner/pull/78/files#diff-0(4)

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com/lviggiano/owner/pull/78
.

Owner

lviggiano commented May 23, 2014

I think that the implementation is correct. But, a unit test, to prove that
utf-8 encoded properties file are loaded properly is needed. You can add
it, or I will, before merging.
Il 22/mag/2014 21:44 "SvetaNesterenko" notifications@github.com ha
scritto:

I would like to contribute to your project and I decided to get started
with this issue. I am not sure if I did this right, so I would appreciate

any comments.

You can merge this Pull Request by running

git pull https://github.com/SvetaNesterenko/owner utf8-fix

Or view, comment on, or merge it at:

#78
Commit Summary

  • UTF-8 encoding properties. Resolves #77

File Changes

  • M
    owner/src/main/java/org/aeonbits/owner/loaders/PropertiesLoader.javahttps://github.com/lviggiano/owner/pull/78/files#diff-0(4)

Patch Links:


Reply to this email directly or view it on GitHubhttps://github.com/lviggiano/owner/pull/78
.

lviggiano added a commit that referenced this pull request May 23, 2014

Merge pull request #78 from SvetaNesterenko/utf8-fix
 UTF-8 encoding properties. Resolves #77

@lviggiano lviggiano merged commit 463875d into lviggiano:master May 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 23, 2014

Owner

Merged, thanks. If you could provide a unit test, then, we can consider #77 closed.

Owner

lviggiano commented May 23, 2014

Merged, thanks. If you could provide a unit test, then, we can consider #77 closed.

@SvetaNesterenko

This comment has been minimized.

Show comment
Hide comment
@SvetaNesterenko

SvetaNesterenko May 23, 2014

Contributor

Thanks, I'll write the test.

Contributor

SvetaNesterenko commented May 23, 2014

Thanks, I'll write the test.

@lviggiano

This comment has been minimized.

Show comment
Hide comment
@lviggiano

lviggiano May 23, 2014

Owner

I'll release asap with your fix. Thank you.

Owner

lviggiano commented May 23, 2014

I'll release asap with your fix. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment