Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] Fix the casing up the version-specific gemfiles #74

Merged
merged 1 commit into from Feb 24, 2017

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee self-assigned this Feb 21, 2017
@oliverklee oliverklee requested a review from lwe February 21, 2017 11:28
@lwe
Copy link
Owner

lwe commented Feb 24, 2017

(Sorry, deleted my previous comment)

Don't think it's reasonable to change the upcasing, because Gemfile itself is also upper-case, I think this is mainly a wrong default by rubocop and we should ignore casing rules for Gemfile* IMO.

Update: and please rebase, thx.

Copy link
Owner

@lwe lwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than change the casing, I'd prefer to move an exclusion like:

Style/FileName:
  Exclude:
    - 'gemfiles/Gemfile.*'

to the primary rubocop.yml config file.

@oliverklee oliverklee force-pushed the cleanup/file-naming branch 2 times, most recently from 190450c to 983e66b Compare February 24, 2017 14:32
@oliverklee
Copy link
Collaborator Author

Done.

@oliverklee
Copy link
Collaborator Author

Strange … I'll investigate the failures.

@lwe
Copy link
Owner

lwe commented Feb 24, 2017

Ahhh, this is why we included the explicit versions in the execution of Rubocop, otherwise it also examines .lock files. Can these be globally ignored maybe?

@lwe
Copy link
Owner

lwe commented Feb 24, 2017

or maybe it's better to simply rename to rails-4-2.gemfile or smth, then it can easily be run on *.gemfile? (i suppose we even discussed this once, but I opposed it, sorry 😄)

@oliverklee
Copy link
Collaborator Author

I've just undone the changes to the RuboCop call. Hopefully, the build should now pass.

@lwe
Copy link
Owner

lwe commented Feb 24, 2017

🎉 thanks

@lwe lwe merged commit 648bc17 into master Feb 24, 2017
@lwe lwe deleted the cleanup/file-naming branch February 24, 2017 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants