Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

321 date column #399

Merged
merged 10 commits into from Sep 7, 2017
Merged

321 date column #399

merged 10 commits into from Sep 7, 2017

Conversation

@mikelolasagasti
Copy link
Contributor

@mikelolasagasti mikelolasagasti commented Sep 29, 2016

Fix proposal for #321

Invert order of columns, setting fixed width for date to 200 and filling space with headline.

@Leiaz
Copy link
Collaborator

@Leiaz Leiaz commented Sep 30, 2016

With your change the favicon ends up at the end of the line. I think it looks better in front of the headline.

@mikelolasagasti
Copy link
Contributor Author

@mikelolasagasti mikelolasagasti commented Sep 30, 2016

Didn't realize about that. Now favicon is before the headlines and the attachment column between headline and date.

@Leiaz
Copy link
Collaborator

@Leiaz Leiaz commented Oct 2, 2016

Nice, thanks !

@Leiaz
Copy link
Collaborator

@Leiaz Leiaz commented Oct 4, 2016

The click to toggle flagged status (line 661) is broken by the column move.

@mikelolasagasti
Copy link
Contributor Author

@mikelolasagasti mikelolasagasti commented Oct 11, 2016

@Leiaz thanks for spotting that issue!

@elpocko
Copy link

@elpocko elpocko commented Oct 30, 2016

I prefer to resize the date column to its minimum width, so it is not visible anymore and does not take up space. I do this because the article date is irrelevant to me.

Would this change break this? Is it still possible to remove the date column?

@GreenLunar
Copy link
Collaborator

@GreenLunar GreenLunar commented Oct 30, 2016

Perhaps a GSettings switch.

@mikelolasagasti
Copy link
Contributor Author

@mikelolasagasti mikelolasagasti commented Nov 1, 2016

Current status: enclosure and date column are on the left
liferea-5
liferea-6

With this patches: enclosure and date column are moved to the right and date has a fixed size so title has all the remaining space
liferea-4
liferea-3

@elpocko
Copy link

@elpocko elpocko commented Nov 1, 2016

Ah, thank you. Date is still irrelevant to me, but at least it won't get in the way anymore. That seems like a good compromise.

@lwindolf
Copy link
Owner

@lwindolf lwindolf commented Mar 26, 2017

@mikelolasagasti The 200px hard-coded do prevent me from merging this... It should be auto-sizing because 200px mean totally different things on a 1280px wide screen width vs mad HiDPi screen widths...

@mikelolasagasti
Copy link
Contributor Author

@mikelolasagasti mikelolasagasti commented Mar 27, 2017

@lwindolf I'll explore other options

@mikelolasagasti
Copy link
Contributor Author

@mikelolasagasti mikelolasagasti commented Mar 27, 2017

@lwindolf now it uses GTK_TREE_VIEW_COLUMN_AUTOSIZE and it seems to do the trick but currently just have my laptop to test.

@Leiaz
Copy link
Collaborator

@Leiaz Leiaz commented Apr 3, 2017

Now there are two date columns :D
It looks like merging went wrong.

The default GTK_TREE_VIEW_COLUMN_GROW_ONLY should work too. Also the doc says :

Please note that GTK_TREE_VIEW_COLUMN_AUTOSIZE are inefficient for large views, and can make columns appear choppy.

@mikelolasagasti
Copy link
Contributor Author

@mikelolasagasti mikelolasagasti commented Apr 3, 2017

Thanks @Leiaz !

I removed the duplicated date column and changed to use GTK_TREE_VIEW_COLUMN_GROW_ONLY.

I tested with Spanish locale and it resizes correctly in my laptop.

image

@Leiaz
Copy link
Collaborator

@Leiaz Leiaz commented Apr 6, 2017

You still have two enclosure icon columns. Don't forget to change the attribute for the icon from "pixbuf" to "gicon".

@mikelolasagasti
Copy link
Contributor Author

@mikelolasagasti mikelolasagasti commented Apr 27, 2017

@Leiaz thanks again for reviewing. I removed the extra column and fixed the flag toggling logic when the favicon is not present.

@Leiaz
Copy link
Collaborator

@Leiaz Leiaz commented May 14, 2017

It looks good 👍

@lwindolf lwindolf merged commit 3309a96 into lwindolf:master Sep 7, 2017
@lwindolf
Copy link
Owner

@lwindolf lwindolf commented Sep 7, 2017

@mikelolasagasti Great work! Having the date out of the way makes focusing on the story titles much more pleasant.

@lwindolf lwindolf self-assigned this Sep 7, 2017
@lwindolf lwindolf added the enhancement label Sep 7, 2017
@lwindolf lwindolf added this to the 1.12.0 milestone Sep 7, 2017
lwindolf pushed a commit that referenced this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants