Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AltTab blocks ESC key from working in other applications #123

Closed
florianorben opened this issue Jan 22, 2020 · 3 comments
Closed

AltTab blocks ESC key from working in other applications #123

florianorben opened this issue Jan 22, 2020 · 3 comments

Comments

@florianorben
Copy link

When AltTab is active (i.e. has been opened, but is not in currently in use) pressing the ESC Key is no longer propagated to other applications.
This is particularly annoying when trying to close modals/dialog windows.

I guess this bug has been introduced here:
phungtuanhoang1996@9fd0c16#diff-b338575fcf6c3370769d63a924a2a1deR52

Presumably changing line 52 to
if type == .keyDown && isEscape && application.appIsBeingUsed {
should fix the bug - I don't have an active switft development setup to test the changes though.

@lwouis
Copy link
Owner

lwouis commented Jan 22, 2020

Oh that's terrible! I will make a fix right away

@lwouis lwouis closed this as completed in 5260619 Jan 22, 2020
lwouis pushed a commit that referenced this issue Jan 22, 2020
## [2.3.4](v2.3.3...v2.3.4) (2020-01-22)

### Bug Fixes

* escape key was absorbed by the inactive app (closes [#123](#123)) ([5260619](5260619))
@lwouis
Copy link
Owner

lwouis commented Jan 22, 2020

@florianorben I just released 2.3.4 which should have this issue fixed. Please feel free to check it out and re-open if it's not

@florianorben
Copy link
Author

@lwouis Working again with 2.3.4! Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants