-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to windows faster #62
Comments
Also closes #11 closes #45 closes #62 BREAKING CHANGE: this brings huge changes to core parts of the codebase. It introduces the use of private APIs that hopefully are should be compatible from macOS 10.12+, but I couldn't test them. I reviewed the whole codebase to clean and improve on performance and readability
Also closes #11 closes #45 closes #62 BREAKING CHANGE: this brings huge changes to core parts of the codebase. It introduces the use of private APIs that hopefully are should be compatible from macOS 10.12+, but I couldn't test them. I reviewed the whole codebase to clean and improve on performance and readability
# [2.0.0](v1.14.4...v2.0.0) (2019-12-27) ### Features * display other spaces/minimized windows (closes [#14](#14)) ([3f5ea25](3f5ea25)), closes [#11](#11) [#45](#45) [#62](#62) ### BREAKING CHANGES * this brings huge changes to core parts of the codebase. It introduces the use of private APIs that hopefully are should be compatible from macOS 10.12+, but I couldn't test them. I reviewed the whole codebase to clean and improve on performance and readability
This ticket and a bunch of others are closed in v2 released today. Feel free to test that new version out and give feedback here! Hopefully you experience better performance, can interact with minimized windows, and interact with windows from other spaces and displays. Cheers! |
Actually I was benchmarking by focusing in-and-out of the System Preferences > Privacy window, which is very slow to come up on my machine for some reason. Indeed for technique introduced in v2 is faster than even the OS when you click on the Dock icon. However, I noticed today that for Outlook which is reasonably fast to appear, the OS is faster than AltTab. So some scenarios are faster, some of slower. I will reopen as a reminder to review this issue taking these scenarios into account |
If I count from when the menubar starts changing to Outlook's, I count:
Some observations:
Here is the slowmo footage I used to compare: |
I just did another series of tests. Note that, similar to previous tests above, the frames are frames on my 240 fps camera, not frames on my macbook 60 fps display.
|
Basically at this point, I think the performance is good enough. I'll close this ticket. It's useful as a reference if we want to improve on this later on, and revisit this work. |
Even if we ignore potential performance issues from #45, after the shortcut is released, the app is slow to switch focus to the target window.
In my tests (using a slow-mo camera), I see HyperSwitch has 3 frames between its UI disappearing, and the target window appearing. For AltTab, it's 10 frames. I'm assuming they use another way to request focus to the OS
Here is the current code (10ms):
The text was updated successfully, but these errors were encountered: