New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use map for environment variables #116

Merged
merged 2 commits into from Dec 19, 2018

Conversation

2 participants
@monstermunchkin
Copy link
Member

monstermunchkin commented Dec 19, 2018

No description provided.

@stgraber

This comment has been minimized.

Copy link
Member

stgraber commented Dec 19, 2018

Travis isn't happy:

shared/util.go:28:6: exported type Environment should have comment or be unexported

monstermunchkin added some commits Dec 19, 2018

shared: Use map for environment variables
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>
test: Update TestSetEnvVariables
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>

@monstermunchkin monstermunchkin force-pushed the monstermunchkin:fixes/env-vars branch from 7e4c6b0 to 406605a Dec 19, 2018

@stgraber stgraber merged commit 05705b6 into lxc:master Dec 19, 2018

3 checks passed

Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment