Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distrobuilder: Add variants for packages and files #211

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@monstermunchkin
Copy link
Member

commented Aug 9, 2019

Signed-off-by: Thomas Hipp thomas.hipp@canonical.com

@monstermunchkin monstermunchkin referenced this pull request Aug 9, 2019
@stgraber

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

@monstermunchkin

Hmm, I was more thinking along the lines of adding a variants field to the PackageSet, File and Action so we don't need to hardcode things like this.

Thoughts?

@monstermunchkin monstermunchkin force-pushed the monstermunchkin:misc/cloud-init branch from 7728cf8 to 03c3e17 Aug 9, 2019

@monstermunchkin monstermunchkin changed the title distrobuilder: Support image variant "cloud" distrobuilder: Add variant for packages and files Aug 9, 2019

@monstermunchkin monstermunchkin changed the title distrobuilder: Add variant for packages and files distrobuilder: Add variants for packages and files Aug 9, 2019

@monstermunchkin monstermunchkin force-pushed the monstermunchkin:misc/cloud-init branch from 03c3e17 to b0486c0 Aug 9, 2019

@monstermunchkin

This comment has been minimized.

Copy link
Member Author

commented Aug 9, 2019

@stgraber rebased and ready for review.

distrobuilder: Add variants for packages and files
Signed-off-by: Thomas Hipp <thomas.hipp@canonical.com>

@monstermunchkin monstermunchkin force-pushed the monstermunchkin:misc/cloud-init branch from b0486c0 to 4750001 Aug 9, 2019

@stgraber

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Excellent, thanks!

@stgraber stgraber merged commit a90bf4f into lxc:master Aug 9, 2019

3 checks passed

Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.