Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apertis #229

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@d4s
Copy link
Contributor

commented Aug 31, 2019

Add the simple downloader and template for Apertis OS -- Debian's derivative.

Add Apertis OS downloader
Simple downloader which relies to "https" URL schema.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

@d4s d4s changed the title Wip/d4s/apertis Add Apertis Aug 31, 2019

@stgraber

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

So looks like the needed artifacts are only available for amd64 and arm64, is that correct?
armhf appears to be missing minimal.

Add Apertis example
Config allows to download and start all Apertis variants,
however for proper work need to start container in privileged mode.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>

@d4s d4s force-pushed the d4s:wip/d4s/apertis branch from 827d4cc to d2471c0 Aug 31, 2019

@d4s

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

So looks like the needed artifacts are only available for amd64 and arm64, is that correct?

No. Looks like you've checked the daily build which may fail to build any artifact.

armhf appears to be missing minimal.

it exists for release/18.12. However I've just changed the version to use to pre-release based on Debian Buster (v2019pre) which should be changed to v2019 after release.

@d4s

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

@stgraber I have a question related to daily builds -- did it have sense to add development builds into lxc-ci? Keeping in mind what some artifacts may have a build failures (like armhf which you mention above) and naming schema for serial includes build ID, i.e. "20190831.0".

@stgraber

This comment has been minimized.

Copy link
Member

commented Aug 31, 2019

We'd normally prefer stable releases that should build fine every day. All failures are retried 3 times automatically and then manually investigated, so if something is expected to fail pretty often, it's not a great fit.

@d4s

This comment has been minimized.

Copy link
Contributor Author

commented Sep 1, 2019

aha, thanks for clarification, so have no sense to add a development version into CI.

As about stable version, what is preferred -- set defaults to current pre-release (as I did in current PR) and later change it to released version or wait for nearest release and update the PR after it?

PS the downloader works for daily and release builds if proper option is provided.

@stgraber stgraber merged commit 907c65f into lxc:master Sep 3, 2019

3 checks passed

Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stgraber

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@monstermunchkin can you send a PR against lxc-ci which adds this to the automatic image builder for whatever releases are supported and on all supported arches (amd64, arm64 and armhf)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.