Skip to content

Commit

Permalink
commands: log at debug not info level when receiving file descriptors
Browse files Browse the repository at this point in the history
Don't spam the logs because we do receive a lot of file descriptors.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
  • Loading branch information
Christian Brauner committed May 4, 2021
1 parent 2c1754e commit 9cc5d48
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/lxc/commands.c
Expand Up @@ -126,7 +126,7 @@ static ssize_t lxc_cmd_rsp_recv_fds(int fd_sock, struct unix_fds *fds,

ret = lxc_abstract_unix_recv_fds(fd_sock, fds, rsp, sizeof(*rsp));
if (ret < 0)
return ret;
return log_error(ret, "Failed to receive file descriptors");

/*
* If we end up here with fewer or more file descriptors the caller
Expand All @@ -135,18 +135,18 @@ static ssize_t lxc_cmd_rsp_recv_fds(int fd_sock, struct unix_fds *fds,
*/

if (fds->flags & UNIX_FDS_RECEIVED_EXACT)
return log_info(ret, "Received exact number of file descriptors %u == %u",
fds->fd_count_max, fds->fd_count_ret);
return log_debug(ret, "Received exact number of file descriptors %u == %u",
fds->fd_count_max, fds->fd_count_ret);

if (fds->flags & UNIX_FDS_RECEIVED_LESS)
return log_info(ret, "Received less file descriptors %u < %u",
fds->fd_count_ret, fds->fd_count_max);
return log_debug(ret, "Received less file descriptors %u < %u",
fds->fd_count_ret, fds->fd_count_max);

if (fds->flags & UNIX_FDS_RECEIVED_MORE)
return log_info(ret, "Received more file descriptors (excessive fds were automatically closed) %u > %u",
fds->fd_count_ret, fds->fd_count_max);
return log_debug(ret, "Received more file descriptors (excessive fds were automatically closed) %u > %u",
fds->fd_count_ret, fds->fd_count_max);

INFO("Command \"%s\" received response", cur_cmdstr);
DEBUG("Command \"%s\" received response", cur_cmdstr);
return ret;
}

Expand Down

0 comments on commit 9cc5d48

Please sign in to comment.