Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua support broken when installing in local userdir #169

Closed
frogstarr78 opened this issue Mar 1, 2014 · 1 comment
Closed

Lua support broken when installing in local userdir #169

frogstarr78 opened this issue Mar 1, 2014 · 1 comment
Assignees
@dwengen
Labels
Bug Confirmed to be a bug
Milestone
lxc-1.0.1

Comments

@frogstarr78
Copy link

I'm attempting to install the lxc as my local user using this command:
./configure --prefix=$HOME
It errs with this message:

Making install in lua-lxc
make[2]: Entering directory `/home/scott/vcs/git/lxc/src/lua-lxc'
make[3]: Entering directory `/home/scott/vcs/git/lxc/src/lua-lxc'
make[3]: Nothing to be done for `install-exec-am'.
 /bin/mkdir -p '/usr/share/lua/5.1'
/bin/mkdir: cannot create directory ‘/usr/share/lua’: Permission denied

I'm installing on Gentoo 3.10.17 x64

Configuring with --disable-lua works fine though.
@stgraber stgraber added this to the lxc-1.0.1 milestone Mar 3, 2014
@stgraber stgraber added the bug label Mar 3, 2014
@ncopa
Copy link
Contributor

ncopa commented Mar 3, 2014

I think the proper fix would be to simply drop using the LUA_INSTALL_[CL]MOD from pkgconfig and simply install things relative --prefix.

Lua would probably not find the module in $HOME but if you set prefix I suppose its up to the user to configure lua to find the modules.

stgraber pushed a commit that referenced this issue Mar 5, 2014
@ncopa @stgraber
lua: respect configure's --prefix
b71f50d 
Install lua files under the confiugred --prefix rather than use the
pkg-config's variables LUA_INSTALL_[CL]MOD.

Users will likely want user --prefix while packagers will use DESTDIR.
Set the default to $datadir/lua/$LUA_VERSION for arch independent
lua modules and $libdir/lua/$LUA_VERSION for arch dependant .so module.

This should work for most distros. If it does not, then packagers
can still do:

  make install lualibdir=$(pkg-config lua --variable=INSTALL_CMOD) ...

This fixes #169

Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
Acked-by: Dwight Engen <dwight.engen@oracle.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
z-image pushed a commit to z-image/lxc that referenced this issue Oct 16, 2016
@ncopa @stgraber
lua: respect configure's --prefix
0917318 
Install lua files under the confiugred --prefix rather than use the
pkg-config's variables LUA_INSTALL_[CL]MOD.

Users will likely want user --prefix while packagers will use DESTDIR.
Set the default to $datadir/lua/$LUA_VERSION for arch independent
lua modules and $libdir/lua/$LUA_VERSION for arch dependant .so module.

This should work for most distros. If it does not, then packagers
can still do:

  make install lualibdir=$(pkg-config lua --variable=INSTALL_CMOD) ...

This fixes lxc#169

Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
Acked-by: Dwight Engen <dwight.engen@oracle.com>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwengen dwengen

Labels
Bug Confirmed to be a bug
Milestone
lxc-1.0.1
Development

No branches or pull requests
4 participants
@frogstarr78 @ncopa @stgraber @dwengen