Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] impact on template downloads in view of SKS Keyserver Network Attack #3068

Open
n8v8R opened this issue Jul 1, 2019 · 1 comment

Comments

@n8v8R
Copy link

commented Jul 1, 2019

To my humble understanding the template downloads are verifying signatures via SKS and thus appreciate clarification whether and to which potential extent the download process could be impacted by

SKS Keyserver Network Under Attack

This attack cannot be mitigated by the SKS keyserver network in any reasonable time period.
The best mitigation that can be applied at present is simple: stop retrieving data from the SKS keyserver network.

https://gist.github.com/rjhansen/67ab921ffb4084c865b3618d6955275f

@n8v8R n8v8R changed the title [RFC] impact of template downloads in view of SKS Keyserver Network Attack [RFC] impact on template downloads in view of SKS Keyserver Network Attack Jul 1, 2019

@stgraber

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

My understanding is that the SKS attack effectively allows for replacing a valid public key entry with a broken/unreadable one, effectively preventing the retrieval of the public key from the SKS network.

So that's effectively a DoS attack. It will not allow an attacker to replace the key with their own so they will not be able to cause systems running LXC to run compromised content.

I think that in the next LXC release, we'll want to take the same approach we did with LXD and remove the GPG handling code, instead requiring the index files be downloaded over HTTPs and then validate the artifacts against the signatures found in those index files.

@stgraber stgraber self-assigned this Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.