New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aufs mount syntax with "br:" not supported #967

Closed
tstarling opened this Issue Apr 13, 2016 · 5 comments

Comments

3 participants
@tstarling

tstarling commented Apr 13, 2016

In the aufs manpage of the current version of aufs-utils, only the br: syntax for branch options is documented, the br= syntax is not mentioned. But lxc only supports the br= syntax, and it fails without any explanation if you try to use the other syntax.

Most mount errors are accompanied at least by an explanatory WARN level log message, but none of the "goto err" cases in aufs_mkdir() or ovl_mkdir() result in a log message, either directly or in the caller mount_entry_create_dir_file(). So all you get is a vague message like

lxc-start: conf.c: lxc_setup: 3920 failed to setup the mount entries for 'container-name'

If the mount is optional, you don't even get that much.

@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Apr 13, 2016

Member

Please tell us which kernel / aufs module source you are using. Lxc has always used br=. It sounds like br= and br: should be equivalent (see discussion in #969), so switching may be ok, but i don't want to break long-time users if we can help it.

Member

hallyn commented Apr 13, 2016

Please tell us which kernel / aufs module source you are using. Lxc has always used br=. It sounds like br= and br: should be equivalent (see discussion in #969), so switching may be ok, but i don't want to break long-time users if we can help it.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Apr 13, 2016

Member

Hi, so I think we'd like to avoid further logging in smaller helper functions for now. We report SYSERROR() back on mount failure and a WARN() when we fail to create a aufs/overlay helper dir.

If the syntax for br: and br= is equivalent it probably be best to stick with br= for simplicity and backwards compatibility; otherwise we'd have to special case br: in there again.
Closing this for now.

Member

brauner commented Apr 13, 2016

Hi, so I think we'd like to avoid further logging in smaller helper functions for now. We report SYSERROR() back on mount failure and a WARN() when we fail to create a aufs/overlay helper dir.

If the syntax for br: and br= is equivalent it probably be best to stick with br= for simplicity and backwards compatibility; otherwise we'd have to special case br: in there again.
Closing this for now.

@brauner brauner closed this Apr 13, 2016

@tstarling

This comment has been minimized.

Show comment
Hide comment
@tstarling

tstarling Apr 13, 2016

Sorry, I didn't realise I would have to spell this out. Yes, the kernel module supports both. lxc should similarly support both. #969 would break lxc for all existing users and I certainly would not recommend it. It is not difficult to support both. I'll submit a pull request if you like.

tstarling commented Apr 13, 2016

Sorry, I didn't realise I would have to spell this out. Yes, the kernel module supports both. lxc should similarly support both. #969 would break lxc for all existing users and I certainly would not recommend it. It is not difficult to support both. I'll submit a pull request if you like.

@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Apr 13, 2016

Member

Oh, I see. Not at all how I interpreted your original email.

As you say that should be easy enough. A PR would be great.

Member

hallyn commented Apr 13, 2016

Oh, I see. Not at all how I interpreted your original email.

As you say that should be easy enough. A PR would be great.

@hallyn hallyn reopened this Apr 13, 2016

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Feb 9, 2018

Member

The aufs driver will be deprecated. For a union filesystem one should use the overlay fs driver which is available in the upstream kernel.

Member

brauner commented Feb 9, 2018

The aufs driver will be deprecated. For a union filesystem one should use the overlay fs driver which is available in the upstream kernel.

@brauner brauner closed this Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment