New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: better error reporting for lxc-start #1234

Merged
merged 1 commit into from Oct 18, 2016

Conversation

2 participants
@brauner
Member

brauner commented Oct 14, 2016

Show outdated Hide outdated src/lxc/tools/lxc_start.c Outdated
Show outdated Hide outdated src/lxc/tools/lxc_start.c Outdated
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Oct 14, 2016

Member

Addressed.

Member

brauner commented Oct 14, 2016

Addressed.

@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Oct 14, 2016

Member

Hm, note I did not mean for that other check to be removed - i simply wanted it also done if getuid() == 0.

Member

hallyn commented Oct 14, 2016

Hm, note I did not mean for that other check to be removed - i simply wanted it also done if getuid() == 0.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Oct 14, 2016

Member

Hm, I'm slow today.

Member

brauner commented Oct 14, 2016

Hm, I'm slow today.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Oct 17, 2016

Member

@hallyn, added the getuid() check.

Member

brauner commented Oct 17, 2016

@hallyn, added the getuid() check.

@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Oct 18, 2016

Member

Hi,

what I've been trying to say is that the access() check might fail even if you are root, in which case container start will still fail later on, so we may as well stop early in that case as well. Do you see any problem with github.com/hallyn/lxc #2016-10-18/br2 ? (github is trying to tell me how to do something cool to link to the branch here but I'm failing)

Member

hallyn commented Oct 18, 2016

Hi,

what I've been trying to say is that the access() check might fail even if you are root, in which case container start will still fail later on, so we may as well stop early in that case as well. Do you see any problem with github.com/hallyn/lxc #2016-10-18/br2 ? (github is trying to tell me how to do something cool to link to the branch here but I'm failing)

tools: better error reporting for lxc-start
Signed-off-by: Christian Brauner <christian.brauner@canonical.com>
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Oct 18, 2016

Member

Nope, all good.

Member

brauner commented Oct 18, 2016

Nope, all good.

@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Oct 18, 2016

Member
Member

hallyn commented Oct 18, 2016

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Oct 18, 2016

Member

I updated. Sorry I was so dense. :D

Member

brauner commented Oct 18, 2016

I updated. Sorry I was so dense. :D

@hallyn hallyn merged commit 70baef7 into lxc:master Oct 18, 2016

4 checks passed

Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
Testsuite Testsuite passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment