New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OCI container creation template #1839

Merged
merged 2 commits into from Oct 3, 2017

Conversation

2 participants
@hallyn
Member

hallyn commented Oct 2, 2017

This adds preliminary (but working) support for creating application
containers from OCI formats. Examples:

sudo lxc-create -t oci -n a1 -- -u oci:../oci:alpine -t alpine

create a container from a local OCI layout in ../oci.

sudo lxc-create -t oci -n u1 -- -u docker://ubuntu -t ubuntu

create a container pulling from the docker hub.

I'm pretty sure we'll wan to fine-tune the way "urls' are
specified. The separate specifying of a 'tag' is unfortunate.
Maybe we can be smart enough to know to pull the name for
dockerhub and the tag for oci:. But for now it simplified things
to the point of making it easy enough to implement and use.

Comments appreciated.

TODO:

  • implement lxc.execute.cmd configuration key
  • pull more of the OCI runtime information like memory/cpu limits

Signed-off-by: Serge Hallyn shallyn@cisco.com

support lxc.execute.cmd container configuration option
Signed-off-by: Serge Hallyn <shallyn@cisco.com>
@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Oct 3, 2017

Member

Hm, please hold off on this. Got a little bug in the entry point parsing.

Member

hallyn commented Oct 3, 2017

Hm, please hold off on this. Got a little bug in the entry point parsing.

@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Oct 3, 2017

Member

Ok, should be good now.

Member

hallyn commented Oct 3, 2017

Ok, should be good now.

Add OCI container creation template
Closes #1813

This adds preliminary (but working) support for creating application
containers from OCI formats.  Examples:

create a container from a local OCI layout in ../oci:

    sudo lxc-create -t oci -n a1 -- -u oci:../oci:alpine

Or, create a container pulling from the docker hub.

    sudo lxc-create -t oci -n u1 -- -u docker://ubuntu

The url is specified in the same format as for 'skopeo copy'.

Comments appreciated.

Signed-off-by: Serge Hallyn <shallyn@cisco.com>

@brauner brauner merged commit c4c133b into lxc:master Oct 3, 2017

4 checks passed

Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
Testsuite Testsuite passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment