New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks: add mount hook to configure access to NVIDIA GPUs #2015

Merged
merged 1 commit into from Dec 19, 2017

Conversation

4 participants
@flx42
Contributor

flx42 commented Dec 8, 2017

This hook requires the nvidia-container-cli tool provided by libnvidia-container:
https://github.com/nvidia/libnvidia-container

For containers that do not have CUDA_VERSION or NVIDIA_VISIBLE_DEVICES
set in the environment, the hook will be a no-op.

To enable in the configuration file:
lxc.hook.mount = /usr/local/share/lxc/hooks/nvidia

Signed-off-by: Felix Abecassis fabecassis@nvidia.com

cc @3XX0

@lxc-jenkins

This comment has been minimized.

Show comment
Hide comment
@lxc-jenkins

lxc-jenkins Dec 8, 2017

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

lxc-jenkins commented Dec 8, 2017

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 8, 2017

Member

jenkins: test this please

Member

brauner commented Dec 8, 2017

jenkins: test this please

@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Dec 9, 2017

Member

Interesting - so this hook will actually break if/when we stop sending the hook args as argv.

Member

hallyn commented Dec 9, 2017

Interesting - so this hook will actually break if/when we stop sending the hook args as argv.

@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Dec 9, 2017

Contributor

@hallyn well, it's not merged, so we can still fix our hooks. I would be fine to do something like:

if [ -n "${LXC_HOOK_ARGS}" ]; then
   $(getopt .... -- "${LXC_HOOK_ARGS}")
else
   $(getopt .... -- "${@}")
fi

But it would require agreeing on the name of the environment variable.

Contributor

flx42 commented Dec 9, 2017

@hallyn well, it's not merged, so we can still fix our hooks. I would be fine to do something like:

if [ -n "${LXC_HOOK_ARGS}" ]; then
   $(getopt .... -- "${LXC_HOOK_ARGS}")
else
   $(getopt .... -- "${@}")
fi

But it would require agreeing on the name of the environment variable.

if [ -z "${CLI_DEBUG}" ]; then
if [ "${LXC_LOG_LEVEL}" = "DEBUG" ] || [ "${LXC_LOG_LEVEL}" = "TRACE" ]; then
rootfs_path="${LXC_ROOTFS_PATH#*:}"
hookdir="${rootfs_path/%rootfs/hook}"

This comment has been minimized.

@flx42

flx42 Dec 9, 2017

Contributor

@hallyn I was wondering if this path was fine for you, it's for the log file of nvidia-container-cli.
If the rootfs is dir:/a/b/c/rootfs, we will write the log in a new directory above: /a/b/c/hook/nvidia.log

@flx42

flx42 Dec 9, 2017

Contributor

@hallyn I was wondering if this path was fine for you, it's for the log file of nvidia-container-cli.
If the rootfs is dir:/a/b/c/rootfs, we will write the log in a new directory above: /a/b/c/hook/nvidia.log

@hallyn

This comment has been minimized.

Show comment
Hide comment
@hallyn

hallyn Dec 9, 2017

Member

Indeed it would require that :)

@brauner - opinion?

Member

hallyn commented Dec 9, 2017

Indeed it would require that :)

@brauner - opinion?

@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Dec 9, 2017

Contributor

By the way, what is the issue with passing the hook arguments as $@?

Contributor

flx42 commented Dec 9, 2017

By the way, what is the issue with passing the hook arguments as $@?

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 9, 2017

Member

By the way, what is the issue with passing the hook arguments as $@?

The issue is that older liblxc versions used to pass a - by now - useless set of arguments in all cases. So they are always there when they clearly don't need to. What we want is to remove them from being passed explicitly so that uses can directly pass the arguments they want without having to swallow the default arguments before. That is just way cleaner.

Member

brauner commented Dec 9, 2017

By the way, what is the issue with passing the hook arguments as $@?

The issue is that older liblxc versions used to pass a - by now - useless set of arguments in all cases. So they are always there when they clearly don't need to. What we want is to remove them from being passed explicitly so that uses can directly pass the arguments they want without having to swallow the default arguments before. That is just way cleaner.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 9, 2017

Member

Indeed it would require that :)

@brauner - opinion?

This is about the name of the environment variable? I'm fine with LXC_HOOK_ARGS. @RicardoSanchezA are you and Yoshinobu working still working on this?

Member

brauner commented Dec 9, 2017

Indeed it would require that :)

@brauner - opinion?

This is about the name of the environment variable? I'm fine with LXC_HOOK_ARGS. @RicardoSanchezA are you and Yoshinobu working still working on this?

@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Dec 9, 2017

Contributor

Ok, I understand better now.
So, to summarize, today if I have the following in my config file:

lxc.hook.mount = /usr/local/share/lxc/hooks/nvidia --debug /tmp/nvidia.log

The arguments passed to my hook will be:

Arg Value
$1 --debug
$2 /tmp/nvidia.log
$3 mycontainer
$4 lxc
$5 mount

I still want to have $1 and $2 be unchanged.
Since we already have LXC_NAME=mycontainer, if we simply add LXC_HOOK_TYPE=mount , then lxc can stop injecting any additional argument on the command line after my own (replacing $4 would probably not be very useful).

Contributor

flx42 commented Dec 9, 2017

Ok, I understand better now.
So, to summarize, today if I have the following in my config file:

lxc.hook.mount = /usr/local/share/lxc/hooks/nvidia --debug /tmp/nvidia.log

The arguments passed to my hook will be:

Arg Value
$1 --debug
$2 /tmp/nvidia.log
$3 mycontainer
$4 lxc
$5 mount

I still want to have $1 and $2 be unchanged.
Since we already have LXC_NAME=mycontainer, if we simply add LXC_HOOK_TYPE=mount , then lxc can stop injecting any additional argument on the command line after my own (replacing $4 would probably not be very useful).

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

confile: add lxc.hooks.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

conf: execute hooks based on lxc.hooks.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

start: pass namespaces as environment variables
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 10, 2017

Member

I sent patches to get rid of the args in #2017 since we need to do it soon and it seemed no one was working on this.

Member

brauner commented Dec 10, 2017

I sent patches to get rid of the args in #2017 since we need to do it soon and it seemed no one was working on this.

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

confile: add lxc.hooks.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

conf: execute hooks based on lxc.hooks.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

start: pass namespaces as environment variables
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

confile: add lxc.hook.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

conf: execute hooks based on lxc.hooks.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 10, 2017

start: pass namespaces as environment variables
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 11, 2017

confile: add lxc.hook.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 11, 2017

conf: execute hooks based on lxc.hooks.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 11, 2017

start: pass namespaces as environment variables
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 11, 2017

Member

Ok, I understand better now.
So, to summarize, today if I have the following in my config file:

lxc.hook.mount = /usr/local/share/lxc/hooks/nvidia --debug /tmp/nvidia.log

The arguments passed to my hook will be:

Arg Value
$1 --debug
$2 /tmp/nvidia.log
$3 mycontainer
$4 lxc
$5 mount

Fwiw, I think they will be:

Arg Value
$1 mycontainer
$2 lxc
$3 mount
$4 --debug
$5 /tmp/nvidia.log

I still want to have $1 and $2 be unchanged.

Given the ordering you still want $4 and $5 be unchanged. That shouldn't be a problem. The way I currently did it in my branch is essentially:

  • introduce lxc.hook.version.
    • This can be either set to 0 or 1. If this is set to 0 then $1, $2, $3 will be passed as arguments as before. If this is set to 1 then $1, $2, $3 will be available in an environment variable LXC_HOOK_ARGS. All other arguments that people specify to their hooks will be passed as arguments and are unaffected by lxc.hooks.version. This also means that in your script you could test whether LXC_HOOK_ARGS exist - if you wanted to - to detect whether the old-style or new-style argument style is used.

    • Setting lxc.hook.version will also have effect on passing arguments to the stop hook. @Blub made it such that for each namespace the stop hook would receive a list of arguments of the form mnt:/proc/<pid>/fd/<nr> net:/proc/<pid>/fd/<nr>. When lxc.hook.version is set to 1 then these namespace file descriptors for the container will be set as individual environment variable (per namespace). That is they will be available as:

      LXC_MNT_NS=/proc/<pid>/fd/<nr>
      LXC_NET_NS=/proc/<pid>/fd/<nr>
      .
      .
      .
      

I'm currently contemplating whether it would make sense to also set LXC_HOOK_VERSION so that scripts could check for the hook version that is used.

Member

brauner commented Dec 11, 2017

Ok, I understand better now.
So, to summarize, today if I have the following in my config file:

lxc.hook.mount = /usr/local/share/lxc/hooks/nvidia --debug /tmp/nvidia.log

The arguments passed to my hook will be:

Arg Value
$1 --debug
$2 /tmp/nvidia.log
$3 mycontainer
$4 lxc
$5 mount

Fwiw, I think they will be:

Arg Value
$1 mycontainer
$2 lxc
$3 mount
$4 --debug
$5 /tmp/nvidia.log

I still want to have $1 and $2 be unchanged.

Given the ordering you still want $4 and $5 be unchanged. That shouldn't be a problem. The way I currently did it in my branch is essentially:

  • introduce lxc.hook.version.
    • This can be either set to 0 or 1. If this is set to 0 then $1, $2, $3 will be passed as arguments as before. If this is set to 1 then $1, $2, $3 will be available in an environment variable LXC_HOOK_ARGS. All other arguments that people specify to their hooks will be passed as arguments and are unaffected by lxc.hooks.version. This also means that in your script you could test whether LXC_HOOK_ARGS exist - if you wanted to - to detect whether the old-style or new-style argument style is used.

    • Setting lxc.hook.version will also have effect on passing arguments to the stop hook. @Blub made it such that for each namespace the stop hook would receive a list of arguments of the form mnt:/proc/<pid>/fd/<nr> net:/proc/<pid>/fd/<nr>. When lxc.hook.version is set to 1 then these namespace file descriptors for the container will be set as individual environment variable (per namespace). That is they will be available as:

      LXC_MNT_NS=/proc/<pid>/fd/<nr>
      LXC_NET_NS=/proc/<pid>/fd/<nr>
      .
      .
      .
      

I'm currently contemplating whether it would make sense to also set LXC_HOOK_VERSION so that scripts could check for the hook version that is used.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 11, 2017

Member

I'm currently contemplating whether it would make sense to also set LXC_HOOK_VERSION so that scripts could check for the hook version that is used.

Without consulting the container's config that is. Hm, I think I'll push a patch for this on top of my branch and see what @hallyn thinks.

Member

brauner commented Dec 11, 2017

I'm currently contemplating whether it would make sense to also set LXC_HOOK_VERSION so that scripts could check for the hook version that is used.

Without consulting the container's config that is. Hm, I think I'll push a patch for this on top of my branch and see what @hallyn thinks.

brauner added a commit to brauner/lxc that referenced this pull request Dec 11, 2017

confile: add lxc.hook.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 11, 2017

start: set LXC_HOOK_VERSION
This can be used by scripts to detect what version of the hooks are used.

Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 11, 2017

conf: execute hooks based on lxc.hooks.version
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 11, 2017

start: pass namespaces as environment variables
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Dec 11, 2017

Contributor

Fwiw, I think they will be [...]

That's not what I'm seeing. I'm seeing my own args first, then the ones injected by lxc.

If this is set to 1 then $1, $2, $3 will be available in an environment variable LXC_HOOK_ARGS

So, LXC_HOOK_ARGS=mycontainer lxc mount? Doesn't seem very convenient. It's easy to split the variable in bash. But if your hook is in C, it won't be very pleasant to have to split the string manually.
Why not just add LXC_HOOK_TYPE=mount then?

Contributor

flx42 commented Dec 11, 2017

Fwiw, I think they will be [...]

That's not what I'm seeing. I'm seeing my own args first, then the ones injected by lxc.

If this is set to 1 then $1, $2, $3 will be available in an environment variable LXC_HOOK_ARGS

So, LXC_HOOK_ARGS=mycontainer lxc mount? Doesn't seem very convenient. It's easy to split the variable in bash. But if your hook is in C, it won't be very pleasant to have to split the string manually.
Why not just add LXC_HOOK_TYPE=mount then?

brauner added a commit to brauner/lxc that referenced this pull request Dec 12, 2017

start: pass namespaces as environment variables
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 12, 2017

network: pass info in env if hook version is 1
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Dec 12, 2017

Contributor

Updated hook for handling lxc.hook.version (or the absence thereof):
https://github.com/flx42/lxc/blob/64bcf8facdd8a51aec33e8fa5a4c420ccfc1a715/hooks/nvidia#L98-L104

Contributor

flx42 commented Dec 12, 2017

Updated hook for handling lxc.hook.version (or the absence thereof):
https://github.com/flx42/lxc/blob/64bcf8facdd8a51aec33e8fa5a4c420ccfc1a715/hooks/nvidia#L98-L104

brauner added a commit to brauner/lxc that referenced this pull request Dec 14, 2017

confile: add lxc.hook.version
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 14, 2017

start: set LXC_HOOK_VERSION
This can be used by scripts to detect what version of the hooks are used.

Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 14, 2017

conf: execute hooks based on lxc.hooks.version
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 14, 2017

start: pass namespaces as environment variables
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

brauner added a commit to brauner/lxc that referenced this pull request Dec 14, 2017

network: pass info in env if hook version is 1
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

@brauner brauner added the Blocked label Dec 14, 2017

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 14, 2017

Member

Labeling this as "blocked" until #2026 is merged. :)

Member

brauner commented Dec 14, 2017

Labeling this as "blocked" until #2026 is merged. :)

@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Dec 14, 2017

Contributor

We have a minor fix to do to this PR. I'll tell you when it's ready for merging :)

Contributor

flx42 commented Dec 14, 2017

We have a minor fix to do to this PR. I'll tell you when it's ready for merging :)

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 14, 2017

Member

@flx42, sure np. :)

Member

brauner commented Dec 14, 2017

@flx42, sure np. :)

@brauner brauner added Incomplete and removed Blocked labels Dec 14, 2017

@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Dec 18, 2017

Contributor

@brauner ready to merge.
And yes, it's signed off :) The test failed.

Contributor

flx42 commented Dec 18, 2017

@brauner ready to merge.
And yes, it's signed off :) The test failed.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 18, 2017

Member

jenkins: test this please

Member

brauner commented Dec 18, 2017

jenkins: test this please

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 18, 2017

Member

@flx42, I'm running shellcheck now. ;)

Member

brauner commented Dec 18, 2017

@flx42, I'm running shellcheck now. ;)

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 18, 2017

Member

@flx42, can you run shellcheck --shell sh hooks/nvidia. We don't strictly require POSIX shell compliance but we strongly encourage it. If this is something you can do and want put the effort in that would be great. If you think it only makes sense to check for bash compliance then run shellcheck hooks/nvidia. :)

Member

brauner commented Dec 18, 2017

@flx42, can you run shellcheck --shell sh hooks/nvidia. We don't strictly require POSIX shell compliance but we strongly encourage it. If this is something you can do and want put the effort in that would be great. If you think it only makes sense to check for bash compliance then run shellcheck hooks/nvidia. :)

hooks: add mount hook to configure access to NVIDIA GPUs
This hook requires the nvidia-container-cli tool provided by libnvidia-container:
https://github.com/nvidia/libnvidia-container

For containers that do not have CUDA_VERSION or NVIDIA_VISIBLE_DEVICES
set in the environment, the hook will be a no-op.

To enable in the configuration file:
lxc.hook.mount = /usr/local/share/lxc/hooks/nvidia

Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Dec 19, 2017

Contributor

Ah well, a lot of the templates are already using bash, I thought it was fine. It would be quite painful to do that in pure /bin/sh.
I did fixes in the script after running shellcheck, but I blame someone else for the warnings on the in_userns function.

Contributor

flx42 commented Dec 19, 2017

Ah well, a lot of the templates are already using bash, I thought it was fine. It would be quite painful to do that in pure /bin/sh.
I did fixes in the script after running shellcheck, but I blame someone else for the warnings on the in_userns function.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 19, 2017

Member

jenkins: test this please

Member

brauner commented Dec 19, 2017

jenkins: test this please

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 19, 2017

Member

LGTM, will merge once the test-suite is happy.

Member

brauner commented Dec 19, 2017

LGTM, will merge once the test-suite is happy.

@brauner brauner merged commit 0720664 into lxc:master Dec 19, 2017

3 of 4 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 19, 2017

Member

@flx42, @3XX0, thanks guys. :) Good work. High-fives overall. :)

Member

brauner commented Dec 19, 2017

@flx42, @3XX0, thanks guys. :) Good work. High-fives overall. :)

geaaru added a commit to geaaru/lxc that referenced this pull request Jul 4, 2018

confile: add lxc.hook.version
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

geaaru added a commit to geaaru/lxc that referenced this pull request Jul 4, 2018

start: set LXC_HOOK_VERSION
This can be used by scripts to detect what version of the hooks are used.

Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

geaaru added a commit to geaaru/lxc that referenced this pull request Jul 4, 2018

conf: execute hooks based on lxc.hooks.version
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

geaaru added a commit to geaaru/lxc that referenced this pull request Jul 4, 2018

start: pass namespaces as environment variables
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

geaaru added a commit to geaaru/lxc that referenced this pull request Jul 4, 2018

network: pass info in env if hook version is 1
Unblocks lxc#2013.
Unblocks lxc#2015.
Closes lxc#1766.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment